-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JBPM-9549] Upgrade SpringBoot to 2.3.4 #1565
Conversation
Jenkins run fdb |
Jenkins run fdb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, waiting on green FDB ;)
Jenkins run fdb |
we need some additional exclusion in jbpm-work-items repository
|
Jenkins run fdb |
1 similar comment
Jenkins run fdb |
failure unrelated. |
* [JBPM-9399] Add support to jBPM and runtime/cluster environments detection * generate files flow (kiegroup#1551) * getProjectTriggering job error solved (kiegroup#1544) * getProjectTriggering job error solved * testing generate_files.yml error * kie-wb-common should not depend on kie-wb-playground (kiegroup#1550) * JBPM-9505: Drop Case Management (Tech Preview) editor (kiegroup#1541) * Update build chain files (kiegroup#1555) Co-authored-by: mareknovotny <mareknovotny@users.noreply.github.com> * Revert "kie-wb-common should not depend on kie-wb-playground (kiegroup#1550)" (kiegroup#1558) This reverts commit 789495d. * Update build chain files (kiegroup#1559) Co-authored-by: mareknovotny <mareknovotny@users.noreply.github.com> * [DROOLS-5860] Updating poms (kiegroup#1560) * [DROOLS-5860] Declaring/updating dependencies * [DROOLS-5860] Renamed module as per PR request * [DROOLS-5860] Declaring kie-pmml-dependencies version * [DROOLS-5860] Fix poms * bump mvel to version 2.4.11.Final (kiegroup#1561) * upgraded to 7.49.0-SNAPSHOT * Bump version.com.thoughtworks.xstream from 1.4.14 to 1.4.15 (kiegroup#1562) Bumps `version.com.thoughtworks.xstream` from 1.4.14 to 1.4.15. Updates `xstream` from 1.4.14 to 1.4.15 - [Release notes](https://github.com/x-stream/xstream/releases) - [Commits](https://github.com/x-stream/xstream/commits) Updates `xstream-hibernate` from 1.4.14 to 1.4.15 - [Release notes](https://github.com/x-stream/xstream/releases) - [Commits](https://github.com/x-stream/xstream/commits) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * JBPM-9542: Remove issue-keeper tool (kiegroup#1563) Due to recent jira authentication changes we decided to stop using issue-keeper tool for preventing test method run. It was replaced by simple '@ignore' junit annotations. For more details see: - https://issues.redhat.com/browse/JBPM-9542 - https://github.com/ibek/issue-keeper * Fixing broken upstream repository deps for kie-wb-common (kiegroup#1568) * Update build chain files (kiegroup#1569) Co-authored-by: Ginxo <Ginxo@users.noreply.github.com> * fixed removal commands in shell scripts (kiegroup#1571) * upgrade to mvel 2.4.12.Final (kiegroup#1570) * [JBPM-9557] Enable sb keycloak test with testcontainers (kiegroup#1567) * Jenkinsfile.buildchain tools replaced by nodejs (kiegroup#1572) * [ISSUE 126] --skipParallelCheckout added to Jenkinsfile.builchain (kiegroup#1574) * BXMSPROD-1124: changed upload scripts of binaries to filemgmt.jboss.org to exclude droolsjbpm-tools" (kiegroup#1556) * [JBPM-9549] Upgrade SpringBoot to 2.3.4 (kiegroup#1565) * Update project-dependencies.yaml (kiegroup#1573) Removal of droolsjbpm-tools repository from community build * Update build chain files (kiegroup#1575) Co-authored-by: mbiarnes <mbiarnes@users.noreply.github.com> * BXMSPROD-1144 test 1 * BXMSPROD-1144 test 2 Co-authored-by: egonzale <egonzale@redhat.com> Co-authored-by: Kirill Gaevskii <kgaevski@redhat.com> Co-authored-by: Roger Martínez <roger600@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: mareknovotny <mareknovotny@users.noreply.github.com> Co-authored-by: Marek Novotný <hotmana76@gmail.com> Co-authored-by: Gabriele Cardosi <gabriele.cardosi@gmail.com> Co-authored-by: Mario Fusco <mario.fusco@gmail.com> Co-authored-by: Michael Biarnes Kiefer <mbiarnes@redhat.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jozef Marko <jomarko@redhat.com> Co-authored-by: Ginxo <Ginxo@users.noreply.github.com> Co-authored-by: Gonzalo Muñoz <gmunozfe@redhat.com> Co-authored-by: mbiarnes <mbiarnes@users.noreply.github.com>
The failure is related because the FDB didn't run completely. It didn't build the optaweb-vehicle-routing repository at all and the change in this PR seems to break the repository. I'm working on a fix (kiegroup/optaweb-vehicle-routing#417) but the job hangs. |
Reproduced hanging test locally. It's a Spring Boot issue (see spring-projects/spring-boot#24249). They fixed it in https://github.com/spring-projects/spring-boot/releases/tag/v2.3.7.RELEASE. Alternative solutions like turning the "deferred" mode manually may be possible (haven't tried that) but I would recommend upgrading to at least Spring Boot 2.3.7. |
EDIT: removed comment about 0 executed tests in employee rostering. Not related to Spring Boot update. |
This reverts commit 9a1b93b.
Jira https://issues.redhat.com/browse/JBPM-9549