Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.5.x] RHDM-24: upgrade wildfly swarm to 2017.12.1 #667

Merged
merged 1 commit into from
Jan 16, 2018
Merged

[7.5.x] RHDM-24: upgrade wildfly swarm to 2017.12.1 #667

merged 1 commit into from
Jan 16, 2018

Conversation

mareknovotny
Copy link
Member

Fixing version differences in wildfly swarm fraction and standalon DM workbenches.

@mareknovotny mareknovotny mentioned this pull request Jan 12, 2018
Merged
@mareknovotny
Copy link
Member Author

Jenkins execute full downstream build

@sutaakar
Copy link
Contributor

Looks good, though I am not sure if I am the right person for the review. Maybe @jhrcek or @rsynek could check this?

@jhrcek
Copy link

jhrcek commented Jan 12, 2018 •
edited

I've no idea how to verify this :/ The only thing that comes to my mind is to check if the final swarm jar contains two versions of jackson artifacts. Hopefully the swarm distro is archived in the full downstream build, in which case I'll check after it finishes.

@rsynek
Copy link
Collaborator

rsynek commented Jan 12, 2018

This version of Wildfly Swarm includes Wildfly 11 artifacts, looking at hollow swarm (JEE microprofile), there is only jackson-databind-2.8.9.jar included, so it should be fine.

@mareknovotny
Copy link
Member Author

Jenkins execute full downstream build

1 similar comment
@mareknovotny
Copy link
Member Author

Jenkins execute full downstream build

@jhrcek
Copy link

jhrcek commented Jan 15, 2018

The cause of the failure is kind of burried inside full-downstream build's console log.
Not sure how to deal with it though :/

[INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (ban-duplicated-classes) @ kie-wb-common-ala-distribution ---
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.112 sec - in org.kie.workbench.common.services.backend.compiler.nio.DefaultMavenIncrementalCompilerTest
Running org.kie.workbench.common.services.backend.compiler.nio.DefaultIncrementalCompilerEnablerTest
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.01 sec - in org.kie.workbench.common.services.backend.compiler.nio.DefaultIncrementalCompilerEnablerTest
Running org.kie.workbench.common.services.backend.compiler.plugin.KieMetadataTest
[INFO] Adding ignore: org.xmlpull.v1.XmlPullParserException
[INFO] Adding ignore: org.xmlpull.v1.XmlPullParser
[INFO] Adding ignore: org.relaxng.datatype.*
[INFO] Adding ignore: org.apache.xmlbeans.xml.stream.XMLName
[INFO] Adding ignore: org.apache.xmlbeans.xml.stream.XMLInputStream
[INFO] Adding ignore: org.apache.xmlbeans.xml.stream.utils.NestedThrowable
[INFO] Adding ignore: org.apache.xmlbeans.xml.stream.utils.NestedThrowable$Util
[INFO] Adding ignore: org.apache.xmlbeans.xml.stream.XMLStreamException
[INFO] Adding ignore: org.apache.xmlbeans.xml.stream.ReferenceResolver
[INFO] Adding ignore: org.apache.xmlbeans.xml.stream.XMLEvent
[INFO] Adding ignore: org.apache.xmlbeans.xml.stream.Location
[INFO] Adding ignore: org.w3c.dom.ElementTraversal
[INFO] Adding ignore: org.w3c.dom.UserDataHandler
[INFO] Adding ignore: org.hornetq.utils.HornetQUtilBundle_$bundle
[INFO] Adding ignore: org.hornetq.utils.HornetQUtilLogger_$logger
[INFO] Adding ignore: javax.interceptor.InvocationContext
[INFO] Adding ignore: javax.inject.Provider
[INFO] Adding ignore: javax.inject.Named
[INFO] Adding ignore: javax.inject.Scope
[INFO] Adding ignore: javax.inject.Qualifier
[INFO] Adding ignore: javax.inject.Singleton
[INFO] Adding ignore: javax.enterprise.*
[INFO] Adding ignore: javax.servlet.*
[INFO] Adding ignore: javax.annotation.*
[INFO] Adding ignore: net.jcip.annotations.*
[INFO] Adding ignore: com.google.gwt.uibinder.rebind.UiBinderWriter
[INFO] Adding ignore: com.google.gwt.uibinder.rebind.UiBinderGenerator
[INFO] Adding ignorable dependency: com.google.gwt:gwt-dev:jar
[INFO]   Adding ignore: *
[INFO] Adding ignorable dependency: org.elasticsearch:elasticsearch:null
[INFO]   Adding ignore: org.joda.time.base.BaseDateTime
[INFO] Adding ignorable dependency: org.kie.server:kie-server-router-proxy:jar
[INFO]   Adding ignore: org.jboss.logging.*
[INFO] Adding ignorable dependency: org.jboss.narayana.tomcat:tomcat-jta:jar
[INFO]   Adding ignore: org.jboss.logging.*
[INFO]   Adding ignore: javax.transaction.*
[INFO] Adding ignorable dependency: io.fabric8:openshift-client:jar
[INFO]   Adding ignore: io.fabric8.kubernetes.client.ConfigFluent
[INFO]   Adding ignore: io.fabric8.kubernetes.client.ConfigBuilder
[INFO]   Adding ignore: io.fabric8.kubernetes.client.ConfigFluentImpl
[WARNING] Rule 0: org.apache.maven.plugins.enforcer.BanDuplicateClasses failed with message:
Duplicate classes found:

  Found in:
    org.ow2.asm:asm-commons:jar:6.0:compile
    com.spotify:docker-client:jar:shaded:3.5.12:compile
  Duplicate classes:
    org/objectweb/asm/commons/CodeSizeEvaluator.class
    org/objectweb/asm/commons/JSRInlinerAdapter.class
    org/objectweb/asm/commons/TableSwitchGenerator.class
    org/objectweb/asm/commons/AnalyzerAdapter.class
    org/objectweb/asm/commons/SerialVersionUIDAdder.class
    org/objectweb/asm/commons/LocalVariablesSorter.class
    org/objectweb/asm/commons/GeneratorAdapter.class
    org/objectweb/asm/commons/RemappingFieldAdapter.class
    org/objectweb/asm/commons/Remapper.class
    org/objectweb/asm/commons/TryCatchBlockSorter$1.class
    org/objectweb/asm/commons/JSRInlinerAdapter$Instantiation.class
    org/objectweb/asm/commons/RemappingSignatureAdapter.class
    org/objectweb/asm/commons/InstructionAdapter.class
    org/objectweb/asm/commons/SimpleRemapper.class
    org/objectweb/asm/commons/StaticInitMerger.class
    org/objectweb/asm/commons/Method.class
    org/objectweb/asm/commons/RemappingAnnotationAdapter.class
    org/objectweb/asm/commons/SerialVersionUIDAdder$Item.class
    org/objectweb/asm/commons/RemappingClassAdapter.class
    org/objectweb/asm/commons/RemappingMethodAdapter.class
    org/objectweb/asm/commons/AdviceAdapter.class
    org/objectweb/asm/commons/TryCatchBlockSorter.class

  Found in:
    org.ow2.asm:asm-tree:jar:6.0:compile
    com.spotify:docker-client:jar:shaded:3.5.12:compile
  Duplicate classes:
    org/objectweb/asm/tree/MethodNode$1.class
    org/objectweb/asm/tree/FieldInsnNode.class
    org/objectweb/asm/tree/LineNumberNode.class
    org/objectweb/asm/tree/LocalVariableAnnotationNode.class
    org/objectweb/asm/tree/TableSwitchInsnNode.class
    org/objectweb/asm/tree/MethodNode.class
    org/objectweb/asm/tree/ClassNode.class
    org/objectweb/asm/tree/IntInsnNode.class
    org/objectweb/asm/tree/TypeInsnNode.class
    org/objectweb/asm/tree/TypeAnnotationNode.class
    org/objectweb/asm/tree/TryCatchBlockNode.class
    org/objectweb/asm/tree/InnerClassNode.class
    org/objectweb/asm/tree/LookupSwitchInsnNode.class
    org/objectweb/asm/tree/LabelNode.class
    org/objectweb/asm/tree/AbstractInsnNode.class
    org/objectweb/asm/tree/ParameterNode.class
    org/objectweb/asm/tree/IincInsnNode.class
    org/objectweb/asm/tree/InsnList.class
    org/objectweb/asm/tree/LocalVariableNode.class
    org/objectweb/asm/tree/FieldNode.class
    org/objectweb/asm/tree/JumpInsnNode.class
    org/objectweb/asm/tree/InsnNode.class
    org/objectweb/asm/tree/FrameNode.class
    org/objectweb/asm/tree/MethodInsnNode.class
    org/objectweb/asm/tree/AnnotationNode.class
    org/objectweb/asm/tree/InvokeDynamicInsnNode.class
    org/objectweb/asm/tree/VarInsnNode.class
    org/objectweb/asm/tree/LdcInsnNode.class
    org/objectweb/asm/tree/InsnList$InsnListIterator.class
    org/objectweb/asm/tree/MultiANewArrayInsnNode.class

  Found in:
    com.spotify:docker-client:jar:shaded:3.5.12:compile
    org.ow2.asm:asm:jar:6.0:compile
  Duplicate classes:
    org/objectweb/asm/AnnotationVisitor.class
    org/objectweb/asm/Handler.class
    org/objectweb/asm/signature/SignatureReader.class
    org/objectweb/asm/FieldVisitor.class
    org/objectweb/asm/TypePath.class
    org/objectweb/asm/TypeReference.class
    org/objectweb/asm/Handle.class
    org/objectweb/asm/AnnotationWriter.class
    org/objectweb/asm/FieldWriter.class
    org/objectweb/asm/Context.class
    org/objectweb/asm/Type.class
    org/objectweb/asm/MethodVisitor.class
    org/objectweb/asm/Attribute.class
    org/objectweb/asm/MethodWriter.class
    org/objectweb/asm/ByteVector.class
    org/objectweb/asm/Opcodes.class
    org/objectweb/asm/Item.class
    org/objectweb/asm/Label.class
    org/objectweb/asm/ClassVisitor.class
    org/objectweb/asm/ClassWriter.class
    org/objectweb/asm/Edge.class
    org/objectweb/asm/signature/SignatureWriter.class
    org/objectweb/asm/Frame.class
    org/objectweb/asm/ClassReader.class
    org/objectweb/asm/signature/SignatureVisitor.class

  Found in:
    org.ow2.asm:asm-commons:jar:6.0:compile
    org.ow2.asm:asm-tree:jar:6.0:compile
    org.ow2.asm:asm:jar:6.0:compile
  Duplicate classes:
    module-info.class

@mareknovotny
Copy link
Member Author

ok, thanks @jhrcek . That is wrong usage of docker spotify client, which is shaded (includes asm). so the result of check is correct. I don't know, why this was not discovered before, this PR is not adding or changing docker-client :(

@mareknovotny mareknovotny changed the title RHDM-24: upgrade wildfly swarm to 2017.12.1 [7.5.x] RHDM-24: upgrade wildfly swarm to 2017.12.1 Jan 15, 2018
@mareknovotny mareknovotny mentioned this pull request Jan 15, 2018
Merged
@mareknovotny
Copy link
Member Author

I am thinking about ignoring banned duplicate classes errors for now and merge this PR

@mareknovotny mareknovotny merged commit 6c4d88e into kiegroup:7.5.x Jan 16, 2018
mareknovotny added a commit to mareknovotny/droolsjbpm-build-bootstrap that referenced this pull request Jan 22, 2018
@mareknovotny
RHDM-24: upgrade wildfly swarm to 2017.12.1 (kiegroup#667)
7d337fe
mareknovotny added a commit to mareknovotny/droolsjbpm-build-bootstrap that referenced this pull request Feb 13, 2018
@mareknovotny
RHDM-24: upgrade wildfly swarm to 2017.12.1 (kiegroup#667)
508aac4
mareknovotny added a commit that referenced this pull request Feb 14, 2018
@mareknovotny
[Do not MERGE yet] RHDM-251 Wildfly 11 (#682)
2d589de 
* Upgrade supported WildFly version to 11.

* adding global ignore for java 9 compatible module class

* RHBPMS-5026 - Version difference of jackson artifacts (#583)

* RHDM-24: upgrade wildfly swarm to 2017.12.1 (#667)

* upgrade of cargo maven plugin for Wildfly11 container
mareknovotny added a commit to mareknovotny/droolsjbpm-build-bootstrap that referenced this pull request Feb 16, 2018
@mareknovotny
RHDM-24: upgrade wildfly swarm to 2017.12.1 (kiegroup#667)
92e4146
mbarkley pushed a commit that referenced this pull request Mar 1, 2018
@mareknovotny @mbarkley
RHDM-251 - Wildfly 11 upgrade (#711)
711c90c 
* Upgrade supported WildFly version to 11.

* RHBPMS-5026 - Version difference of jackson artifacts (#583)

* RHDM-24: upgrade wildfly swarm to 2017.12.1 (#667)

* adding global ignore for java 9 compatible module class

* upgrade of cargo maven plugin for Wildfly11 container

* Create extension for Errai EmbeddedWildFlyLauncher to disable logging subsystem.

* RHDM-250: adding enforcer ignore for ASM classes (#684) (#709)
@mareknovotny mareknovotny deleted the RHDM-24 branch March 21, 2020 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsynek rsynek rsynek approved these changes

@sutaakar sutaakar sutaakar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@mareknovotny @sutaakar @jhrcek @rsynek