Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE YET] JBPM-6627 - Extend tests for Kie Server Controller Integration tests #1363

Closed
wants to merge 3 commits into from
Closed

[DO NOT MERGE YET] JBPM-6627 - Extend tests for Kie Server Controller Integration tests #1363

wants to merge 3 commits into from

Conversation

jakubschwan
Copy link
Contributor

Tests for JBPM-6243
@cristianonicolai Can you take a look?

@jakubschwan
Copy link
Contributor Author

Jenkins retest this

@cristianonicolai
Copy link
Contributor

@jakubschwan overall looks good to me. I was only wondering if you could get a green build by disabling those tests that are known to not be supported in the REST API yet. That way we could enable it as we include the new endpoints.

@jakubschwan
Copy link
Contributor Author

Sure, in REST API are now not supported REST endpoints for Rule capability and Runtime monitoring, right? But there still be some tests failures because of web socket test (e.g. not thrown exception on wrong method entrance - not existing container)
I'll push changes later today.

@jakubschwan
Copy link
Contributor Author

Test failures:

  • RestKieControllerManagementIntegrationTest - missing REST endpoints for the SpecManagementService, implementation should be add in to the org.kie.server.controller.rest.RestSpecManagementServiceImpl
  • WebSocketKieControllerManagementIntegrationTest - failed copy of template configuration - what should be copied into the new template?
  • WebSocketKieControllerRuleCapabilitiesIntegrationTest - failing test with not correct entries - entry should be checked and if is not correct then exception should be thrown. + scanning not working
  • WebSocketKieControllerRuntimeManagementIntegrationTest - wrong data returned for getContainers + failing test with not correct entries

@cristianonicolai Can you check tests results too? If you think that some scenario is not right please let me know, otherwise I'll start to creating issues.

jakubschwan
jakubschwan commented Feb 14, 2018
View reviewed changes
...rg/kie/server/integrationtests/controller/KieControllerRuntimeManagementIntegrationTest.java
assertThat(serverInstances.getServerInstanceKeys()).hasSize(1);
ServerInstanceKey serverInstance = serverInstances.getServerInstanceKeys()[0];
SoftAssertions.assertSoftly(softly -> {
softly.assertThat(serverInstance.getServerName()).isEqualTo(kieServerInfo.getName());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cristianonicolai What is expected name of the server instance? I think it should be same as name of the Kie Server or at least server instance should contain it. But in this test failed with message: expected:<"[KieServer@/kie-server-services]"> but was:<"[a0e625bf-251d-3c1f-ad11-0a17f1c14e21@localhost:37668]">

@cristianonicolai cristianonicolai mentioned this pull request Apr 5, 2018
Merged
@mswiderski
Copy link
Contributor

any plans to get this merged? if not please close

@jakubschwan
Copy link
Contributor Author

I think it can be closed. Tests were include in PRs with fix, right @cristianonicolai ?

@cristianonicolai
Copy link
Contributor

@jakubschwan correct, thanks a lot for this reproducers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jakubschwan @cristianonicolai @mswiderski