[PLANNER-1553] Able to configure thread pool queue size in execution … #1862
Conversation
| @@ -88,12 +88,16 @@ public void init(KieServerImpl kieServer, KieServerRegistry registry) { | |||
| // If new jobs are submitted and all threads are busy, the default reject policy will kick in. | |||
| int availableProcessorCount = Runtime.getRuntime().availableProcessors(); | |||
| int resolvedActiveThreadCount = Math.max(1, availableProcessorCount - 2); | |||
| int queueSize = Integer.parseInt(System.getProperty( | |||
| KieServerConstants.KIE_OPTAPLANNER_THREAD_POOL_QUEUE_SIZE, String.valueOf(resolvedActiveThreadCount))); | |||
| logger.info("Creating a ThreadPoolExecutor with corePoolSize = " + resolvedActiveThreadCount + "," | |||
There was a problem hiding this comment.
Is this information important enough to deserve info log level? Wouldn't be enough to use debug level?
There was a problem hiding this comment.
I was under impression that component's configuration values deserve INFO level. And also helpful from support point of view.
For example)
2019-07-10 16:26:36,400 INFO [org.jbpm.executor.impl.ExecutorImpl] (EJB default - 1) Starting jBPM Executor Component ...
- Thread Pool Size: 1
- Retries per Request: 3
- Load from storage interval: 0 SECONDS (if less or equal 0 only initial sync with storage)
But if you push again for DEBUG level, it's fine for me to change. Please let me know your thought.
There was a problem hiding this comment.
Sounds reasonable, lets keep there INFO.
There was a problem hiding this comment.
@sutaakar ok, I 'll presume you're ok with merging this now?
| @@ -112,6 +112,8 @@ | |||
| public static final String KIE_SERVER_ROUTER = "org.kie.server.router"; | |||
| public static final String KIE_SERVER_ROUTER_ATTEMPT_INTERVAL = "org.kie.server.router.connect"; | |||
|
|
|||
| public static final String KIE_OPTAPLANNER_THREAD_POOL_QUEUE_SIZE = "org.optaplanner.server.ext.thread.pool.queue.size"; | |||
There was a problem hiding this comment.
Why the ".ext" in the name? Which other properties do that convention too?
There was a problem hiding this comment.
This property is used only for OptaplannerKieServerExtension and it's identified by "org.optaplanner.server.ext.XXX".
However, if you suggest any property name, I will follow :)
There was a problem hiding this comment.
Agreed, this name makes sense. Thanks!
…server
It doesn't contain a unit test because I'm not sure about the way/place for such a test (But I tested manually on my RHPAM 7.3.1 and confirmed it works expectedly). If there is a suitable way/place, please kindly guide me. Thanks!