Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBPM-8922] RemoteBusinessRuleTaskHandler does not work with https url #1952

Closed
wants to merge 1 commit into from

Conversation

elguardian
Copy link
Member

force https detection during load balancing.

Copy link
Contributor

@mswiderski mswiderski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall ok, just few minor comments

@elguardian
Copy link
Member Author

sorry about the confusion. The problem is more how the system should behave (i messed up with the PR). The test case relevant should be https://github.com/kiegroup/droolsjbpm-integration/pull/1952/files#diff-3794651273729e747889499f86dea895R18

This test fails during kie services client constructor because the init of the server client requires at least one endpoint to be available.

In the jira reported the https is failing because the truststore is not configured (I created a test case regarding load balancing that prooves that it works with http and https) but what about if you try to deploy while there is no endpoint available (real endpoint down) ? Not really sure if this needs to fail or not). The jira of this is not really a bug but a missconfiguration so not really sure if this was on purpose or not. @mswiderski wdyt ?

@mswiderski
Copy link
Contributor

@elguardian in general the endpoint should be available, at least one at the time of creation of kie server client. So if that is not available I'd say it's really an edge case and the kie server client itself can't do much about it.
Personally I prefer to fail fast when there are no endpoints available as it could be temporarily or it can be as simple as typo and thus way more severe.

@elguardian elguardian closed this Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants