Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JBPM-8976: Fix kie-server expected capabilities comparison #1977

Merged
merged 3 commits into from Jan 22, 2020
Merged

JBPM-8976: Fix kie-server expected capabilities comparison #1977

merged 3 commits into from Jan 22, 2020

Conversation

jomarko
Copy link

@jomarko jomarko commented Jan 14, 2020

elguardian
elguardian approved these changes Jan 14, 2020
View reviewed changes
Copy link
Member

@elguardian elguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thx @jomarko

@jomarko
Copy link
Author

jomarko commented Jan 14, 2020

jenkins execute full downstream build

@jomarko jomarko changed the title JBPM-8976: Fix kie-server expected capabilities log message JBPM-8976: Fix kie-server expected capabilities comparison Jan 14, 2020
hasys
hasys approved these changes Jan 14, 2020
View reviewed changes
Copy link
Member

@hasys hasys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jomarko I tested at runtime and it looks like there are no warnings related to this issue any more, thank you!

P.S. I didn't look at code/tests and don't know SonarCloud rules for this repository, so I just confirm that warning messages described below are not shown anymore in the server log.

08:49:29,837 WARN  [org.kie.server.controller.impl.KieServerControllerImpl] (default task-6) Server id test-kie-server capabilities expected [KieServer, BRM, BPM, CaseMgmt, BPM-UI, BRP, DMN, Swagger] but there was [RULE, PROCESS, PLANNING]
08:49:29,837 WARN  [org.kie.server.controller.rest.RestKieServerControllerImpl] (default task-6) Server with id 'test-kie-server' failed to connect

@jomarko
Copy link
Author

jomarko commented Jan 15, 2020

jenkins execute full downstream build

@jomarko
Copy link
Author

jomarko commented Jan 16, 2020

jenkins please retest this

@jomarko
Copy link
Author

jomarko commented Jan 16, 2020

jenkins execute full downstream build

@jomarko
Copy link
Author

jomarko commented Jan 16, 2020

jenkins please retest this

1 similar comment
@jomarko
Copy link
Author

jomarko commented Jan 16, 2020

jenkins please retest this

@jomarko
Copy link
Author

jomarko commented Jan 16, 2020

jenkins execute full downstream build

1 similar comment
@jomarko
Copy link
Author

jomarko commented Jan 17, 2020

jenkins execute full downstream build

@jomarko
Copy link
Author

jomarko commented Jan 17, 2020

jenkins please retest this

@jomarko
Copy link
Author

jomarko commented Jan 20, 2020

jenkins execute full downstream build

@jomarko
Copy link
Author

jomarko commented Jan 20, 2020

jenkins please retest this

@jomarko
Copy link
Author

jomarko commented Jan 20, 2020

jenkins execute full downstream build

@elguardian
Copy link
Member

failure is not related. Just keep in mind sonar.

@sonarcloud
Copy link

sonarcloud bot commented Jan 21, 2020 •
edited

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@elguardian
Copy link
Member

1 vulnerability has no impact here.
1 code smells is more about preferences of sonar than a real one.

@jomarko
Copy link
Author

jomarko commented Jan 21, 2020

@elguardian do you agree with merge?

@wmedvede
Copy link
Member

Hi @jomarko @elguardian
I'd tested the fix locally and seems to work well. From my side I'd suggest to merge this ASAP since I believe there might be use cases where the KieController stays stucked in a loop trying to connect to the server, since the check always gives an error.
my 2 cents.

@elguardian
Copy link
Member

@jomarko yep
@kiegroup/gatekeepers

@MarianMacik MarianMacik merged commit 7b2bb48 into kiegroup:master Jan 22, 2020
mbiarnes pushed a commit to mbiarnes/droolsjbpm-integration that referenced this pull request Jan 24, 2020
@mbiarnes
JBPM-8976: Fix kie-server expected capabilities comparison (kiegroup#…
ace86f3 
…1977)

* JBPM-8976: Fix kie-server expected capabilities comparision

For more details see https://issues.redhat.com/browse/JBPM-8976

* JBPM-8976: Fix KieControllerValidationIntegrationTest

* JBPM-8976: Do not use static field double brace initialization

(cherry picked from commit 7b2bb48)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasys hasys hasys approved these changes

@sutaakar sutaakar sutaakar approved these changes

@elguardian elguardian elguardian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@jomarko @elguardian @wmedvede @hasys @sutaakar @MarianMacik