Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBPM-8910] How to use a "OR" query operator in a custom query in the query-parameters #2009

Merged
merged 1 commit into from Feb 26, 2020

Conversation

elguardian
Copy link
Member

modify payload and added an adapter for recursive query param / ast expression

@elguardian
Copy link
Member Author

depends on kiegroup/jbpm#1595

@elguardian
Copy link
Member Author

Jenkins retest this please.

Copy link
Contributor

@mswiderski mswiderski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall ok, but would be good to actually have a integration test showing this in action

@elguardian
Copy link
Member Author

failure not related.
Jenkins retest this please.

@gmunozfe
Copy link
Member

@elguardian just some typos and a small suggestion.

… query-parameters

modify payload and added an adapter for recursive query param / ast expression
@sonarcloud
Copy link

sonarcloud bot commented Feb 20, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

18.8% 18.8% Coverage
0.0% 0.0% Duplication

@gmunozfe gmunozfe self-requested a review February 20, 2020 21:59
Copy link
Member

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @elguardian, very good job!

@elguardian elguardian merged commit 2c85b6a into kiegroup:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants