PLANNER-1627: TaskAssigningPlanning & TaskAssignigRuntime kie-sever extensions (target architecture) #2034

wmedvede · 2020-03-02T16:41:32Z

No description provided.

wmedvede · 2020-03-02T16:42:41Z

Hi @rsynek @triceo this PR is basically the refactoring of the task assigning stuff merged on Friday to the final location in kie-server-parent.
Would you mind review?

Thanks

depends on: kiegroup/droolsjbpm-build-bootstrap#1205

rsynek · 2020-03-03T09:00:45Z

@sutaakar any idea if there is any owner of KIE server now who could review PRs as this one?

sutaakar · 2020-03-03T09:26:04Z

I guess the Kie server doesn't have any specific owner now.

rsynek

Tested that the new artifacts are contained in kie-server assembly. The assembly for ee8 deploys to Wildfly and the new extensions are properly activated.

triceo

Approved, assuming the owner of KIE Server has also approved this.

wmedvede · 2020-03-03T13:55:15Z

Hi @krisv your name came up in today's sprint planning meeting as the person candidate for approving/reviewing this Kie Server related PR.
Would you mind have look?

Thanks!

FYI @ge0ffrey

wmedvede · 2020-03-04T07:59:28Z

looks like jenknis job failed due error below but the PR status wasn't refreshed

08:47:15 GitHub pull request #2034 of commit ac3cfc6, no merge conflicts.
08:47:15 Unable to query GitHub for status of PullRequestorg.kohsuke.github.HttpException: Server returned HTTP response code: -1, message: 'null' for URL: https://api.github.com/repos/kiegroup/droolsjbpm-integration/pulls/2034
08:47:15 at org.kohsuke.github.Requester.parse(Requester.java:646)
08:47:15 at org.kohsuke.github.Requester.parse(Requester.java:607)

wmedvede · 2020-03-04T08:01:16Z

jenkins retest this

wmedvede · 2020-03-04T11:37:28Z

Un-related tests failed. Looks like random failures.

++++++++++++++++++
org.kie.server.integrationtests.controller.WebSocketKieControllerRuleCapabilitiesIntegrationTest.testScanNow[0: JSON KieServicesConfiguration{transport=REST, serverUrl='http://localhost:42146/kie-server-services/services/rest/server'}]

Failing for the past 1 build (Since Unstable#715 )
Took 4 min 5 sec.
add description
Error Message
Synchronization failed for defined timeout: 240000 milliseconds.
Stacktrace
java.util.concurrent.TimeoutException: Synchronization failed for defined timeout: 240000 milliseconds.

++++++++++++++

org.kie.server.integrationtests.controller.WebSocketKieControllerRuleCapabilitiesIntegrationTest.testStartAndStopScanner[0: JSON KieServicesConfiguration{transport=REST, serverUrl='http://localhost:42146/kie-server-services/services/rest/server'}]

Failing for the past 1 build (Since Unstable#715 )
Took 1 min 15 sec.
add description
Error Message
The following assertion failed:

expected:<[STARTED]> but was:<[CREATING]>
Stacktrace
org.assertj.core.api.SoftAssertionError:

The following assertion failed:

expected:<[STARTED]> but was:<[CREATING]>

wmedvede · 2020-03-04T11:38:00Z

jenkins retest this

wmedvede · 2020-03-04T15:49:45Z

jenkins execute full downstream build

sutaakar · 2020-03-05T09:23:09Z

@wmedvede About https://github.com/kiegroup/droolsjbpm-integration/blob/ac3cfc6ea00b0e89473177ee1b40dd26bb9e7db3/kie-server-parent/kie-server-remote/kie-server-rest/kie-server-rest-task-assigning-runtime/src/main/java/org/kie/server/remote/rest/taskassigning/runtime/TaskAssigningRuntimeResource.java , if I understand it correctly then these endpoints can be also used by third party user, right? Have you considered adding there Swagger annotations?

sutaakar · 2020-03-05T09:41:10Z

@wmedvede Do you plan to provide implementation of UserSystemService for other application servers or possibly other authentication options like LDAP or Keycloak?

sutaakar · 2020-03-05T09:46:19Z

Have you considered implementing full e2e scenario showing how this functionality can be used by end users of Kie server?

…xtensions (target architecture) - Refactors the modules in jbpm-task-assigning to the definitive location in kie-server-parent

…xtensions (target architecture) - Removes the no longer needed jbpm-task-assigning first level module

…xtensions (target architecture) - Swagger configuration - Standard queries

wmedvede · 2020-03-10T16:57:44Z

@wmedvede About https://github.com/kiegroup/droolsjbpm-integration/blob/ac3cfc6ea00b0e89473177ee1b40dd26bb9e7db3/kie-server-parent/kie-server-remote/kie-server-rest/kie-server-rest-task-assigning-runtime/src/main/java/org/kie/server/remote/rest/taskassigning/runtime/TaskAssigningRuntimeResource.java , if I understand it correctly then these endpoints can be also used by third party user, right? Have you considered adding there Swagger annotations?

third party users should avoid using this method since the shouldn't try to executePlannings or more flexible queries are provided. But no problem, the swagger information was added.

wmedvede · 2020-03-10T17:04:30Z

@wmedvede Do you plan to provide implementation of UserSystemService for other application servers or possibly other authentication options like LDAP or Keycloak?

It's not the priority right now, i.e. out of this PR. Even so we have to see, since getting the users from the UserSystemService is not only getting the user + group information it implies also grabbing business related information like skills and affinities which may vary in impredectible ways depending on the particular integration, client. etc. I believe we should avoid ending up in kind of "generic" business data extractor for LDAP, keycloack, etc. Anyway, we can see this in the future.

wmedvede · 2020-03-10T17:08:10Z

Have you considered implementing full e2e scenario showing how this functionality can be used by end users of Kie server?

Let's see if I go the time for setting up all this, right now there are still other development pieces pending. But I'll try to add some tasks consumption examples in the getting started guide.

sonarcloud · 2020-03-10T21:36:38Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
18 Code Smells

84.1% Coverage
0.6% Duplication

wmedvede · 2020-03-11T09:54:51Z

jenkins execute full downstream build

ge0ffrey · 2020-03-11T10:27:24Z

Hi guys,

This PR has been open a while, let's get this wrapped up and merged. We have 3 approvals for this PR and no rejections. If no one objects further, I 'll merge it tomorrow.

@krisv @sutaakar Let me know if you want a few more days to review first, otherwise I 'll merge tomorrow, so it's easier to further polish the task assignment work in additional, smaller PR's.

sutaakar

Ok for me.

ge0ffrey · 2020-03-11T14:04:33Z

Have you considered implementing full e2e scenario showing how this functionality can be used by end users of Kie server?

Let's see if I go the time for setting up all this, right now there are still other development pieces pending. But I'll try to add some tasks consumption examples in the getting started guide.

Good question - such an end to end scenario would make an interesting video or blog post too. It's an important piece of the puzzle.

wmedvede · 2020-03-12T07:54:13Z

Well full build failed in non related tests but all kie-server, business central and jbpm-server artifacts were generated well.

It looks like there are non related DMNDesinger errors breaking the build:

Test Result (45 failures / +45)

org.kie.workbench.common.dmn.showcase.client.selenium.DMNDesignerKogitoSeleniumIT.testConnectorKnowledgeRequirement
org.kie.workbench.common.dmn.showcase.client.selenium.DMNDesignerKogitoSeleniumIT.testInputData
org.kie.workbench.common.dmn.showcase.client.selenium.DMNDesignerKogitoSeleniumIT.testConnectorAuthorityRequirement
org.kie.workbench.common.dmn.showcase.client.selenium.DMNDesignerKogitoSeleniumIT.testBasicModel
org.kie.workbench.common.dmn.showcase.client.selenium.DMNDesignerKogitoSeleniumIT.testBusinessKnowledgeModelExpressionLiteral
org.kie.workbench.common.dmn.showcase.client.selenium.DMNDesignerKogitoSeleniumIT.testNodeStyling

rsynek · 2020-03-13T12:32:52Z

jenkins execute full downstream build

rsynek · 2020-03-16T07:19:25Z

jenkins execute full downstream build

wmedvede · 2020-03-16T13:13:48Z

This is failing again due to non related tests but, looks like all related tests and artifacts were generated.

Expected condition failed: waiting for visibility of element located by By.className: qe-docks-item-W-org.kie.dmn.decision.navigator (tried for 10 second(s) with 500 milliseconds interval)
Stacktrace
org.openqa.selenium.TimeoutException: Expected condition failed: waiting for visibility of element located by By.className: qe-docks-item-W-org.kie.dmn.decision.navigator (tried for 10 second(s) with 500 milliseconds interval)
at org.kie.workbench.common.dmn.showcase.client.selenium.DMNDesignerKogitoSeleniumIT.openDMNDesigner(DMNDesignerKogitoSeleniumIT.java:122)
Caused by: org.openqa.selenium.NoSuchElementException:
Cannot locate an element using By.className: qe-docks-item-W-org.kie.dmn.decision.navigator
For documentation on this error, please visit: http://seleniumhq.org/exceptions/no_such_element.html
Build info: version: '3.13.0', revision: '2f0d292', time: '2018-06-25T15:24:21.231Z'
System info: host: 'rhba-jenkins.rhev-ci-vms.eng.rdu2.redhat.com', ip: '127.0.0.1', os.name: 'Linux', os.arch: 'amd64', os.version: '3.10.0-1062.4.1.el7.x86_64', java.version: '1.8.0_202'
Driver info: driver.version: unknown
at org.kie.workbench.common.dmn.showcase.client.selenium.DMNDesignerKogitoSeleniumIT.openDMNDesigner(DMNDesignerKogitoSeleniumIT.java:122)

rsynek · 2020-03-16T14:07:19Z

@wmedvede I have pointed @jomarko at this PR, let's see.

jomarko · 2020-03-16T15:06:32Z

The failed tests are 100% unrelated. feel free to merge. I reported jira for myself and started to investigate here https://issues.redhat.com/browse/KOGITO-1458

rsynek · 2020-03-16T18:15:52Z

Merging based on the investigation of failed tests in FDB.

jomarko · 2020-03-17T08:47:37Z

Failing tests are due to https://issues.redhat.com/browse/DROOLS-5170

wmedvede requested review from rsynek and triceo March 2, 2020 17:02

wmedvede force-pushed the PLANNER-1627-2 branch from b7ab279 to ac3cfc6 Compare March 3, 2020 08:08

rsynek requested a review from sutaakar March 3, 2020 08:59

rsynek approved these changes Mar 3, 2020

View reviewed changes

triceo approved these changes Mar 3, 2020

View reviewed changes

wmedvede requested a review from krisv March 3, 2020 13:52

ge0ffrey approved these changes Mar 6, 2020

View reviewed changes

wmedvede added 3 commits March 10, 2020 17:02

PLANNER-1627: TaskAssigningPlanning & TaskAssignigRuntime kie-sever e…

b287461

…xtensions (target architecture) - Refactors the modules in jbpm-task-assigning to the definitive location in kie-server-parent

PLANNER-1627: TaskAssigningPlanning & TaskAssignigRuntime kie-sever e…

1b396e9

…xtensions (target architecture) - Removes the no longer needed jbpm-task-assigning first level module

PLANNER-1627: TaskAssigningPlanning & TaskAssignigRuntime kie-sever e…

dbf25c1

…xtensions (target architecture) - Swagger configuration - Standard queries

wmedvede force-pushed the PLANNER-1627-2 branch from ac3cfc6 to dbf25c1 Compare March 10, 2020 16:53

sutaakar approved these changes Mar 11, 2020

View reviewed changes

rsynek merged commit ae12431 into kiegroup:master Mar 16, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PLANNER-1627: TaskAssigningPlanning & TaskAssignigRuntime kie-sever extensions (target architecture) #2034

PLANNER-1627: TaskAssigningPlanning & TaskAssignigRuntime kie-sever extensions (target architecture) #2034

wmedvede commented Mar 2, 2020

wmedvede commented Mar 2, 2020 •

edited

rsynek commented Mar 3, 2020

sutaakar commented Mar 3, 2020

rsynek left a comment

triceo left a comment

wmedvede commented Mar 3, 2020

wmedvede commented Mar 4, 2020

wmedvede commented Mar 4, 2020

wmedvede commented Mar 4, 2020

wmedvede commented Mar 4, 2020

wmedvede commented Mar 4, 2020

sutaakar commented Mar 5, 2020

sutaakar commented Mar 5, 2020

sutaakar commented Mar 5, 2020

wmedvede commented Mar 10, 2020

wmedvede commented Mar 10, 2020

wmedvede commented Mar 10, 2020

sonarcloud bot commented Mar 10, 2020

wmedvede commented Mar 11, 2020

ge0ffrey commented Mar 11, 2020

sutaakar left a comment

ge0ffrey commented Mar 11, 2020 •

edited

wmedvede commented Mar 12, 2020

rsynek commented Mar 13, 2020

rsynek commented Mar 16, 2020

wmedvede commented Mar 16, 2020

rsynek commented Mar 16, 2020

jomarko commented Mar 16, 2020

rsynek commented Mar 16, 2020

jomarko commented Mar 17, 2020

PLANNER-1627: TaskAssigningPlanning & TaskAssignigRuntime kie-sever extensions (target architecture) #2034

PLANNER-1627: TaskAssigningPlanning & TaskAssignigRuntime kie-sever extensions (target architecture) #2034

Conversation

wmedvede commented Mar 2, 2020

wmedvede commented Mar 2, 2020 • edited

rsynek commented Mar 3, 2020

sutaakar commented Mar 3, 2020

rsynek left a comment

Choose a reason for hiding this comment

triceo left a comment

Choose a reason for hiding this comment

wmedvede commented Mar 3, 2020

wmedvede commented Mar 4, 2020

wmedvede commented Mar 4, 2020

wmedvede commented Mar 4, 2020

wmedvede commented Mar 4, 2020

wmedvede commented Mar 4, 2020

sutaakar commented Mar 5, 2020

sutaakar commented Mar 5, 2020

sutaakar commented Mar 5, 2020

wmedvede commented Mar 10, 2020

wmedvede commented Mar 10, 2020

wmedvede commented Mar 10, 2020

sonarcloud bot commented Mar 10, 2020

wmedvede commented Mar 11, 2020

ge0ffrey commented Mar 11, 2020

sutaakar left a comment

Choose a reason for hiding this comment

ge0ffrey commented Mar 11, 2020 • edited

wmedvede commented Mar 12, 2020

rsynek commented Mar 13, 2020

rsynek commented Mar 16, 2020

wmedvede commented Mar 16, 2020

rsynek commented Mar 16, 2020

jomarko commented Mar 16, 2020

rsynek commented Mar 16, 2020

jomarko commented Mar 17, 2020

wmedvede commented Mar 2, 2020 •

edited

ge0ffrey commented Mar 11, 2020 •

edited