Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JBPM-9247] Fields attribute isn't processed in Accept header #2163

Merged
merged 1 commit into from Jul 22, 2020
Merged

[JBPM-9247] Fields attribute isn't processed in Accept header #2163

merged 1 commit into from Jul 22, 2020

Conversation

sutaakar
Copy link
Contributor

Signed-off-by: Karel Suta ksuta@redhat.com

@sutaakar sutaakar requested a review from fjtirado July 20, 2020 14:43
@sutaakar
Copy link
Contributor Author

@fjtirado I have moved your test to JbpmRestIntegrationTest as it gathers also other header related tests.

MarianMacik
MarianMacik approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@MarianMacik MarianMacik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one suggestion :)

...ts-jbpm/src/test/java/org/kie/server/integrationtests/jbpm/rest/JbpmRestIntegrationTest.java Show resolved Hide resolved
@sutaakar
[JBPM-9247] Fields attribute isn't processed in Accept header
70f39d0 
Signed-off-by: Karel Suta <ksuta@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_202) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@MarianMacik
Copy link
Member

Test failure not related.

@MarianMacik MarianMacik merged commit 3f5e2ac into kiegroup:master Jul 22, 2020
@sutaakar sutaakar deleted the JBPM-9247 branch July 22, 2020 08:31
sutaakar added a commit to sutaakar/droolsjbpm-integration that referenced this pull request Aug 4, 2020
@sutaakar
[JBPM-9247] Fields attribute isn't processed in Accept header (kiegro…
c3b487c 
…up#2163)

Signed-off-by: Karel Suta <ksuta@redhat.com>
MarianMacik pushed a commit that referenced this pull request Aug 4, 2020
@sutaakar
[RHPAM-3085] [RHPAM-3086] Wrong HTTP media type separator used in Kie…
c59ce3d 
… server (#2178)

* [JBPM-9225] Wrong HTTP media type separator used in Kie server (#2146)

Signed-off-by: Karel Suta <ksuta@redhat.com>

* [JBPM-9247] Fields attribute isn't processed in Accept header (#2163)

Signed-off-by: Karel Suta <ksuta@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarianMacik MarianMacik MarianMacik approved these changes

@fjtirado fjtirado fjtirado approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@sutaakar @MarianMacik @fjtirado