Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JBPM-9317] userTaskService.saveContent doesn't work #2216

Merged
merged 1 commit into from Sep 1, 2020
Merged

[JBPM-9317] userTaskService.saveContent doesn't work #2216

merged 1 commit into from Sep 1, 2020

Conversation

elguardian
Copy link
Member

This was referenced Aug 31, 2020
Merged
Merged
@elguardian
Copy link
Member Author

depends on
kiegroup/droolsjbpm-knowledge#461
kiegroup/jbpm#1747
#2216

@elguardian
Copy link
Member Author

Jenkins retest this please.

@elguardian
Copy link
Member Author

Jenkin retest this please.

@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

52.9% 52.9% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_202) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

afalhambra
afalhambra suggested changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@afalhambra afalhambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only cosmetic changes, nothing major. Looks good

...configuration/src/main/java/org/jbpm/springboot/security/SpringSecurityIdentityProvider.java Show resolved Hide resolved
...configuration/src/main/java/org/jbpm/springboot/security/SpringSecurityIdentityProvider.java Show resolved Hide resolved
...configuration/src/main/java/org/jbpm/springboot/security/SpringSecurityIdentityProvider.java Show resolved Hide resolved
afalhambra
afalhambra approved these changes Sep 1, 2020
View reviewed changes
Copy link
Contributor

@afalhambra afalhambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks @elguardian

@elguardian elguardian merged commit 1d51e03 into kiegroup:master Sep 1, 2020
@elguardian elguardian deleted the JBPM-9317 branch September 1, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afalhambra afalhambra afalhambra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@elguardian @afalhambra