New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JBPM-9405] Provide API method to signal process instance with correlation key #2262
Conversation
54cbd1d
to
0b5254f
Compare
Jenkins retest this please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work, just a few comments and request. Thanks
.../kie-server-services-jbpm/src/main/java/org/kie/server/services/jbpm/ProcessServiceBase.java
Outdated
Show resolved
Hide resolved
.../kie-server-services-jbpm/src/main/java/org/kie/server/services/jbpm/ProcessServiceBase.java
Outdated
Show resolved
Hide resolved
...rest/kie-server-rest-jbpm/src/main/java/org/kie/server/remote/rest/jbpm/ProcessResource.java
Outdated
Show resolved
Hide resolved
...te/kie-server-client/src/main/java/org/kie/server/client/impl/ProcessServicesClientImpl.java
Outdated
Show resolved
Hide resolved
...te/kie-server-client/src/main/java/org/kie/server/client/impl/ProcessServicesClientImpl.java
Show resolved
Hide resolved
...s-jbpm/src/test/java/org/kie/server/integrationtests/jbpm/ProcessServiceIntegrationTest.java
Show resolved
Hide resolved
...s-jbpm/src/test/java/org/kie/server/integrationtests/jbpm/ProcessServiceIntegrationTest.java
Show resolved
Hide resolved
...s-jbpm/src/test/java/org/kie/server/integrationtests/jbpm/ProcessServiceIntegrationTest.java
Show resolved
Hide resolved
kie-server-parent/kie-server-remote/kie-server-client/src/build/revapi-config.json
Outdated
Show resolved
Hide resolved
...r-parent/kie-server-remote/kie-server-rest/kie-server-rest-jbpm/src/build/revapi-config.json
Outdated
Show resolved
Hide resolved
c71c5ed
to
6c5f5e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about this, but it seems there are changes in new files which I don't think they are related to this PR/BAPL.
These are:
- https://github.com/kiegroup/droolsjbpm-integration/blob/6c5f5e68fcdf5d6770c80a63767902444d67e28d/kie-server-parent/kie-server-router/kie-server-router-proxy/src/main/java/org/kie/server/router/Configuration.java
- https://github.com/kiegroup/droolsjbpm-integration/blob/6c5f5e68fcdf5d6770c80a63767902444d67e28d/kie-server-parent/kie-server-router/kie-server-router-proxy/src/main/java/org/kie/server/router/ContainerInfo.java
- https://github.com/kiegroup/droolsjbpm-integration/blob/6c5f5e68fcdf5d6770c80a63767902444d67e28d/kie-server-parent/kie-server-router/kie-server-router-proxy/src/main/java/org/kie/server/router/repository/ConfigurationMarshaller.java
- https://github.com/kiegroup/droolsjbpm-integration/blob/6c5f5e68fcdf5d6770c80a63767902444d67e28d/kie-server-parent/kie-server-router/kie-server-router-proxy/src/test/java/org/kie/server/router/ConfigurationTest.java
Am I missing something here?
@afalhambra removed. mistake with the command line |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work @elguardian - thanks
SonarCloud Quality Gate failed. 0 Bugs |
Jira JBPM-9405
Added rest endpoints and interfaces.
depends on :
kiegroup/jbpm#1767