Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHDM-1461] allow to define an AgendaFilter when starting a process #2265

Merged
merged 2 commits into from Oct 8, 2020

Conversation

mariofusco
Copy link
Member

No description provided.

@elguardian
Copy link
Member

@elguardian
Copy link
Member

remove the package-lock.json from the commit.

@mariofusco I can see only one "but"
if the StartProcessCommand now accepts a filter I don't see in any commit how that can be used from the integration point of view. You added a new attribute there and this can be used as command. so how do we plan to support that when we are sending a command to kie server ? I guess something in the api server code should allow to pass the AgendaFilter right ?

@mariofusco
Copy link
Member Author

@elguardian I added the AgendaFilter to the StartProcess command. It should work exactly in the same way of the FireAllRules command. So the kie-server should receive that command with the serialized AgendaFilter and act accordingly. Am I missing something?

@sonarcloud
Copy link

sonarcloud bot commented Oct 7, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@elguardian
Copy link
Member

@mariofusco Just curious about what sort of AgendaFilter. Maybe I am missing something but I did not see any implementation that could be serialize/deserialize to be used in a marshaller

@mariofusco
Copy link
Member Author

@elguardian we have some predefined and serializable AgendaFilter implementations, see for instance https://github.com/kiegroup/drools/blob/master/drools-core/src/main/java/org/drools/core/base/RuleNameEqualsAgendaFilter.java and https://github.com/kiegroup/drools/blob/master/drools-core/src/main/java/org/drools/core/base/RuleNameStartsWithAgendaFilter.java

In the same way I think that users can define their own AgendaFilter implementations and make them serializable as we did with those ones.

@mariofusco mariofusco merged commit 5d7d6e3 into kiegroup:master Oct 8, 2020
@mariofusco mariofusco deleted the rhdm1461 branch October 8, 2020 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants