[JBPM-9558] KIE using XStream does not complain on unknown fields #2369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjtirado
force-pushed
the
JBPM-9558
branch
5 times, most recently
from
e968f70
to
a9c33a1
Compare
fjtirado
force-pushed
the
JBPM-9558
branch
2 times, most recently
from
c3761e5
to
ddd70b3
Compare
fjtirado
commented
Jan 13, 2021
...t/kie-server-api/src/main/java/org/kie/server/api/marshalling/xstream/XStreamMarshaller.java
Outdated
Show resolved
Hide resolved
fjtirado
commented
Jan 13, 2021
...t/kie-server-api/src/main/java/org/kie/server/api/marshalling/xstream/XStreamMarshaller.java
Outdated
Show resolved
Hide resolved
|
marshaller is created upon deployment and cached so there is not need for multithread. You can add user space objects during creation to the marshaller and ignore them as upon deployment you will have access to any java class in the kjar |
Changed to use Custom mapper and thread local |
fjtirado
force-pushed
the
JBPM-9558
branch
3 times, most recently
from
d51c0c5
to
4171af3
Compare
|
@elguardian Ready to re-review |
elguardian
reviewed
Jan 15, 2021
...t/kie-server-api/src/main/java/org/kie/server/api/marshalling/xstream/XStreamMarshaller.java
Outdated
Show resolved
Hide resolved
elguardian
reviewed
Jan 15, 2021
...t/kie-server-api/src/main/java/org/kie/server/api/marshalling/xstream/XStreamMarshaller.java
Outdated
Show resolved
Hide resolved
elguardian
reviewed
Jan 15, 2021
...t/kie-server-api/src/main/java/org/kie/server/api/marshalling/xstream/XStreamMarshaller.java
Outdated
Show resolved
Hide resolved
afalhambra
reviewed
Jan 15, 2021
kie-server-parent/kie-server-api/src/main/java/org/kie/server/api/marshalling/Marshaller.java
Outdated
Show resolved
Hide resolved
...-server-api/src/test/java/org/kie/server/api/marshalling/CustomXstreamMarshallerBuilder.java
Outdated
Show resolved
Hide resolved
...arent/kie-server-api/src/test/java/org/kie/server/api/marshalling/XStreamMarshallerTest.java
Outdated
Show resolved
Hide resolved
| @@ -35,7 +35,8 @@ public Marshaller build(Set<Class<?>> classes, MarshallingFormat format, ClassLo | |||
| return new XStreamMarshaller(classes, classLoader) { | |||
| @Override | |||
| protected void buildMarshaller(Set<Class<?>> classes, ClassLoader classLoader) { | |||
| xstream = XStreamUtils.createNonTrustingXStream(new PureJavaReflectionProvider(), new DomDriver("UTF-8", new XmlFriendlyNameCoder("_-", "_"))); | |||
| xstream = XStreamUtils.createNonTrustingXStream(new PureJavaReflectionProvider(), new DomDriver("UTF-8", new XmlFriendlyNameCoder("_-", "_")) | |||
| , next -> new CustomElementIgnore(next)); | |||
There was a problem hiding this comment.
the only way to get a buildMarshaller with this ignoreUnknownFields feature is by using and passing this new CustomElementIgnore - so I'm just thinking whether it would be worth to make it public instead of protected - otherwise we are forcing customer to create a package with the same structure - or am I wrong? wdyt?
There was a problem hiding this comment.
This class is intended to be used only in inherited classes, so protected is right
Adding ElementIgnoringMapper custom implementation.
|
Kudos, SonarCloud Quality Gate passed! |
|
@elguardian I think we are ready to go |
gmunozfe
reviewed
Jan 18, 2021
...arent/kie-server-api/src/test/java/org/kie/server/api/marshalling/XStreamMarshallerTest.java
Show resolved
Hide resolved
elguardian
approved these changes
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to "relax" deserialization requirements, user can specifiy as parameter of contentype, ignoreUnknown=true, which will ignore unknown fields durign xstream deserialization.
JIRA:
link
Depends on
kiegroup/kie-soup#173