[JBPM-9611] Command resource returns HTTP OK response status code even for failure scenarios #2396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afalhambra
reviewed
Feb 16, 2021
.../kie-server-rest-drools/src/main/java/org/kie/server/remote/rest/drools/CommandResource.java
Outdated
Show resolved
Hide resolved
.../kie-server-rest-drools/src/main/java/org/kie/server/remote/rest/drools/CommandResource.java
Outdated
Show resolved
Hide resolved
...parent/kie-server-remote/kie-server-rest/kie-server-rest-drools/src/build/revapi-config.json
Outdated
Show resolved
Hide resolved
fjtirado
force-pushed
the
JBPM-9611
branch
2 times, most recently
from
131966b
to
f9905c7
Compare
afalhambra
approved these changes
Feb 16, 2021
.../kie-server-rest-drools/src/main/java/org/kie/server/remote/rest/drools/CommandResource.java
Outdated
Show resolved
Hide resolved
gmunozfe
reviewed
Feb 17, 2021
...parent/kie-server-remote/kie-server-rest/kie-server-rest-drools/src/build/revapi-config.json
Outdated
Show resolved
Hide resolved
fjtirado
force-pushed
the
JBPM-9611
branch
5 times, most recently
from
9636bf7
to
79d4dfc
Compare
|
SonarCloud Quality Gate failed. |
elguardian
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API and test changed to return different HTTP codes depeding on service result.
JIRA:
link