Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JBPM-9625] Allow to bypass the authenticated user in the KIE REST API that is adding users or groups as potential owners #2402

Merged
merged 2 commits into from Mar 10, 2021
Merged

[JBPM-9625] Allow to bypass the authenticated user in the KIE REST API that is adding users or groups as potential owners #2402

merged 2 commits into from Mar 10, 2021

Conversation

elguardian
Copy link
Member

@sutaakar
Copy link
Contributor

@elguardian Could you provide some test coverage, or should I take care of it?

@elguardian elguardian force-pushed the JBPM-9625 branch 2 times, most recently from 481dad2 to 3e8b33c Compare March 1, 2021 08:31
@elguardian elguardian requested a review from sutaakar March 1, 2021 08:31
@sutaakar
Copy link
Contributor

sutaakar commented Mar 1, 2021

@elguardian Do you plan to provide some additional test coverage, or should I take care of it?

@elguardian
Copy link
Member Author

@sutaakar I would appreciate if you take care of it. thx

@elguardian
Copy link
Member Author

Jenkins retest this please

@elguardian
Copy link
Member Author

Jenkins retest this

@sutaakar
Copy link
Contributor

sutaakar commented Mar 8, 2021

@elguardian Test coverage prepared as elguardian#5
Feel free to add it to your branch, or can be done as separate PR here.

elguardian and others added 2 commits March 9, 2021 09:24
@elguardian
[JBPM-9625] Allow to bypass the authenticated user in the KIE REST AP…
4e33a81 
…I that is adding users or groups as potential owners
@sutaakar @elguardian
[JBPM-9625] Test coverage for user assigning by different user
b890608 
Signed-off-by: Karel Suta <ksuta@redhat.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 9, 2021 •
edited

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 25 Code Smells

29.4% 29.4% Coverage
10.0% 10.0% Duplication

@elguardian elguardian merged commit 5b11f08 into kiegroup:master Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sutaakar sutaakar sutaakar approved these changes

@MarianMacik MarianMacik MarianMacik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@elguardian @sutaakar @MarianMacik