Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AF-2811: Required Process Variable Tags shouldn't be accepted in forms when empty #2450

Merged
merged 2 commits into from Apr 16, 2021
Merged

AF-2811: Required Process Variable Tags shouldn't be accepted in forms when empty #2450

merged 2 commits into from Apr 16, 2021

Conversation

akumar074
Copy link
Member

@akumar074 akumar074 commented Apr 9, 2021 •
edited

  • Added "required" and "readonly" property to FormField by tags
  • Fixed validation for input box in ProcessInstance form

JIRA:
AF-2811
RHPAM-3047

referenced Pull Requests:
kiegroup/kie-wb-common#3609
kiegroup/jbpm-wb#1486

Original PR : #2398

How to retest this PR or trigger a specific build:

  • a pull request please add comment: Jenkins retest this

  • a full downstream build please add comment: Jenkins run fdb

  • a compile downstream build please add comment: Jenkins run cdb

  • a full production downstream build please add comment: Jenkins execute product fdb

  • an upstream build please add comment: Jenkins run upstream

@akumar074
AF-2811: Required Process Variable Tags shouldn't be accepted in form…
a09af68 
…s when empty

 * Added required and readonly property to FormField by tags in KieServer and Embedded forms
 * fixed validation for input box in ProcessInstance form

(cherry picked from commit 95791d17c3e373df0b5b6b0f118f4e591985619f)
@akumar074
AF-2811: Required Process Variable Tags shouldn't be accepted in form…
55e9f09 
…s when empty

 * Added required and readonly property to FormField by tags in KieServer and Embedded forms
 * fixed validation for input box in ProcessInstance form

(cherry picked from commit 77f2022da71bc738530ddc5472c2e225866140a6)
@akumar074
Copy link
Member Author

Jenkins run fdb

@sonarcloud
Copy link

sonarcloud bot commented Apr 9, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@akumar074
Copy link
Member Author

Jenkins run fdb

3 similar comments
@akumar074
Copy link
Member Author

Jenkins run fdb

@akumar074
Copy link
Member Author

Jenkins run fdb

@akumar074
Copy link
Member Author

Jenkins run fdb

@tomasdavidorg
Copy link
Contributor

tomasdavidorg commented Apr 12, 2021 •
edited

Hi @akumar074 ,
I created 2 process variables - 1 required and 1 readonly and I tried these two scenarios:

  1. ✅ I deployed process without generating forms. This was ok. The form contained two inputs. First one had to be non-empty. The second couldn't be modified. Process started only if the required was filled.
  2. ⛔ I generated forms in the process. The forms was not generated correctly. The first input was not required and the second was not readonly. When I started the process without value in the required input, I got an error message. After I filled the input the error is still visible.

Error message:
Unable to complete your request. The following exception occurred: "Unable to create response: Variable 'abc' in process instance '8' violated".

image

I think this worked when I tried the master branch PR last time. I will also check it tomorrow on the master branch.

@akumar074
Copy link
Member Author

Jenkins run fdb

@tomasdavidorg tomasdavidorg mentioned this pull request Apr 13, 2021
Merged
@akumar074
Copy link
Member Author

@tomasdavidorg The behaviour you mentioned is indeed a bug. In Jira, the issue is faced with autogenerated forms. so this PR aims to resolve the same. Can we create a separate Jira for the issue mentioned above. WDYT?

@tomasdavidorg
Copy link
Contributor

Hi @akumar074, I can agree with that.

@tomasdavidorg
Copy link
Contributor

@akumar074 Thanks for reporting the issue https://issues.redhat.com/browse/RHPAM-3595. Approving.

pefernan
pefernan approved these changes Apr 14, 2021
View reviewed changes
Copy link
Member

@pefernan pefernan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@paulovmr paulovmr merged commit a4ce302 into kiegroup:7.52.x Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pefernan pefernan pefernan approved these changes

@tomasdavidorg tomasdavidorg tomasdavidorg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@akumar074 @tomasdavidorg @pefernan @paulovmr