Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JBPM-9780] Accept all kafka properties #2510

Merged
merged 1 commit into from Jun 22, 2021
Merged

[JBPM-9780] Accept all kafka properties #2510

merged 1 commit into from Jun 22, 2021

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Jun 11, 2021 •
edited

JIRA:

link

@fjtirado fjtirado marked this pull request as ready for review June 11, 2021 16:08
@fjtirado fjtirado force-pushed the JBPM-9780 branch 2 times, most recently from 6a048cf to a0b718c Compare June 14, 2021 08:49
gmunozfe
gmunozfe suggested changes Jun 14, 2021
View reviewed changes
Copy link
Member

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take into account that some properties have the same name for producer & consumer (CommonClientConfigs) and they should be added to both lists.
Also, a comment related to exception caught when getting the producer and a minor comment for enhancing the test.

...ervices-kafka/src/test/java/org/kie/server/services/jbpm/kafka/KafkaServerExtensionTest.java Outdated Show resolved Hide resolved
...ver-services-kafka/src/main/java/org/kie/server/services/jbpm/kafka/KafkaServerProducer.java Show resolved Hide resolved
...er-services-kafka/src/main/java/org/kie/server/services/jbpm/kafka/KafkaServerExtension.java Outdated Show resolved Hide resolved
@fjtirado fjtirado force-pushed the JBPM-9780 branch 2 times, most recently from c564789 to d2fc196 Compare June 14, 2021 12:11
@fjtirado fjtirado requested a review from gmunozfe June 14, 2021 12:12
gmunozfe
gmunozfe approved these changes Jun 14, 2021
View reviewed changes
Copy link
Member

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, excellent work @fjtirado !

@elguardian
Copy link
Member

Jenkins retest this please

1 similar comment
@elguardian
Copy link
Member

Jenkins retest this please

@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@elguardian elguardian merged commit c631b53 into kiegroup:master Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmunozfe gmunozfe gmunozfe approved these changes

@elguardian elguardian elguardian approved these changes

@afalhambra afalhambra Awaiting requested review from afalhambra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@fjtirado @elguardian @gmunozfe