JBPM-9942 When try to attach a document the file can not greater tha… #2648

bxf12315 · 2021-11-10T08:52:10Z

…n 2 MB

Thank you for submitting this pull request

JIRA: (please edit the JIRA link if it exists)

[link](JBPM-9942)

referenced Pull Requests: (please edit the URLs of referenced pullrequests if they exist)

paste the link(s) from GitHub here
link 2
link 3 etc.

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:

a pull request please add comment: Jenkins retest this
a full downstream build please add comment: Jenkins run fdb
a compile downstream build please add comment: Jenkins run cdb
a full production downstream build please add comment: Jenkins execute product fdb
an upstream build please add comment: Jenkins run upstream

bxf12315 · 2021-11-10T08:52:58Z

Jenkins run fdb

sonarcloud · 2021-11-10T14:19:18Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

prashuts · 2021-11-16T05:17:50Z

Jenkins run fdb

bxf12315 · 2021-12-13T09:46:53Z

Jenkins run fdb

nmirasch · 2021-12-20T08:55:26Z

...s/kie-server-services-jbpm-ui/src/main/resources/form-templates-providers/js/kieserver-ui.js

+
+				fileData.get(input.id).data = srcData;
+				fileReader.readAsDataURL(fileToLoad);
+				// console.log("Converted Base64 version is " + srcData);


@bxf12315 Could you please remove this comment?

@pefernan The code created by Maciej, if srcaData is very huge, the cost is very high, what do you think we remove it?

@bxf12315 honestly I'd keep it as it is for now (or with small changes) since right now the idea is to post the docs content as a part of a json object. So we don't have much more options than reading the doc content here.
I think the general assessment on forms is that they are not inteded to upload heavy documents, so I'd say that this is ok keep it like this. If there's a need to attach big documents, I'd recommend other strategies than using a form.

Back to the first message in this thread - please remove the commented line.

nmirasch · 2021-12-20T08:59:42Z

@pefernan could you take a look when you have a chance?Thanks!

pefernan · 2021-12-20T09:06:59Z

@jstastny-cz please take a look too :P

pefernan

I'm ok with the change, I'd say that it's reasonable to wait for the file reader to finish the doc upload before converting the content into a dataurl. I'm pretty sure that we cannot do much more for large docs. However, I cannot make this work locally. I built an example with docs, the upload seem to work, but the filereader isn't reading the file content and submitting the form always ends with an empty doc. I'd say this is not a problem introduced by this change, but I think this should be addressed.

sonarcloud · 2022-02-11T17:00:41Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

bxf12315 · 2022-03-11T17:11:46Z

Jenkins retest this

bxf12315 · 2022-03-11T17:11:59Z

Jenkins run fdb

mareknovotny · 2022-05-11T12:37:04Z

jenkins retest this please

mareknovotny · 2022-05-12T09:15:58Z

@nmirasch @pefernan @jstastny-cz please review

there were update on the PR

pefernan

@bxf12315 good! it works fine, I added a comment with something I'd change (removing a console.log) that would make this run faster, but I'd consider this optional.

Thanks!

...s/kie-server-services-jbpm-ui/src/main/resources/form-templates-providers/js/kieserver-ui.js

mareknovotny · 2022-05-13T13:40:13Z

jenkins retest this please

jstastny-cz · 2022-05-16T05:49:29Z

Jenkins retest this

jstastny-cz · 2022-05-16T09:35:25Z

When I am attaching any file (even small in size), then pass it to a Human Task and try to download, the download does not start and server log shows:

11:33:16,166 ERROR [org.jbpm.workbench.pr.backend.server.ProcessDocumentServlet] (default task-8) Error occured during document retrieval "Unexpected HTTP response code when requesting URI 'http://localhost:8080/kie-server/services/rest/server/documents/d964c9d6-955e-454b-bf4e-cdc9811347b6'! Error code: 404, message: "Document with id d964c9d6-955e-454b-bf4e-cdc9811347b6 not found"".

When trying with big file, the weird thing to me is that the opload occurs instantly, so wondering if the saving actually works.

jstastny-cz · 2022-05-16T10:41:10Z

When I am attaching any file (even small in size), then pass it to a Human Task and try to download, the download does not start and server log shows:
11:33:16,166 ERROR [org.jbpm.workbench.pr.backend.server.ProcessDocumentServlet] (default task-8) Error occured during document retrieval "Unexpected HTTP response code when requesting URI 'http://localhost:8080/kie-server/services/rest/server/documents/d964c9d6-955e-454b-bf4e-cdc9811347b6'! Error code: 404, message: "Document with id d964c9d6-955e-454b-bf4e-cdc9811347b6 not found"".
When trying with big file, the weird thing to me is that the opload occurs instantly, so wondering if the saving actually works.

This was due to not having properly configured marshaller. Moving further.

mareknovotny · 2022-05-16T15:05:12Z

@jstastny-cz please approve this too before merging.

mareknovotny · 2022-05-16T15:05:58Z

the error happened in jacoco instrumentation build after the green one of build with tests

mareknovotny · 2022-05-16T15:06:07Z

jenkins retest this please

jstastny-cz · 2022-05-17T06:06:17Z

@mareknovotny we're discussing issue with @bxf12315, I am seeing a NPE with a simple process.

jstastny-cz · 2022-05-17T06:48:58Z

Server log provides:

org.kie.server.api.exception.KieServicesHttpException: Unexpected HTTP response code when requesting URI 'http://localhost:8080/kie-server/services/rest/server/containers/jbpm9942_1.0/processes/jbpm9942.P1/instances'! Error code: 500, message: "Unable to create response: [jbpm9942.P1:5 - Task:3] -- null"
        at deployment.business-central.war//org.kie.server.client.impl.AbstractKieServicesClientImpl.createExceptionForUnexpectedResponseCode(AbstractKieServicesClientImpl.java:667)
        at deployment.business-central.war//org.kie.server.client.impl.AbstractKieServicesClientImpl.makeHttpPostRequestAndCreateCustomResponse(AbstractKieServicesClientImpl.java:364)
        at deployment.business-central.war//org.kie.server.client.impl.AbstractKieServicesClientImpl.makeHttpPostRequestAndCreateCustomResponse(AbstractKieServicesClientImpl.java:344)
        at deployment.business-central.war//org.kie.server.client.impl.ProcessServicesClientImpl.startProcess(ProcessServicesClientImpl.java:309)
        at deployment.business-central.war//org.jbpm.workbench.forms.display.backend.FormRendererProxyServlet.doPost(FormRendererProxyServlet.java:111)

Root cause:

Caused by: java.lang.NullPointerException
    at deployment.kie-server.war//org.apache.commons.io.FileUtils.writeByteArrayToFile(FileUtils.java:2843)
    at deployment.kie-server.war//org.apache.commons.io.FileUtils.writeByteArrayToFile(FileUtils.java:2826)
    at deployment.kie-server.war//org.jbpm.document.service.impl.DocumentStorageServiceImpl.saveDocument(DocumentStorageServiceImpl.java:87)
    at deployment.kie-server.war//org.jbpm.document.marshalling.DocumentMarshallingStrategy.marshal(DocumentMarshallingStrategy.java:68)
....

bxf12315 · 2022-05-17T07:18:02Z

@mareknovotny we're discussing issue with @bxf12315, I am seeing a NPE with a simple process.

The PR has a bug, I need to do in-depth research.

bxf12315 · 2022-05-17T16:13:20Z

@jstastny-cz please check it. Thanks

...s/kie-server-services-jbpm-ui/src/main/resources/form-templates-providers/js/kieserver-ui.js

mareknovotny · 2022-05-18T08:13:16Z

failed test in all runs GHA ans Jenkins too in org.kie.server.client.LoadBalancerClientTest.testDefaultLoadBalancerNoServersAvailable No available endpoints found

jstastny-cz · 2022-05-25T08:28:43Z

Jenkins retest this please
The built artifacts are not available anymore.

jstastny-cz · 2022-05-25T08:29:32Z

Jenkins retest this

… 2 MB

pefernan

+1 thanks @bxf12315

sonarcloud · 2022-05-25T18:42:45Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

jstastny-cz

LGTM.
With sufficient undertow post-size limit the ultimate boundary we have is the Java heap space. In my settings I've managed to overcome that limit and resulted in out of memory error. Which is expected and behaves same in BC or kie-server forms.

… 2 MB (kiegroup#2648)

mareknovotny · 2022-07-27T12:23:09Z

have you back ported to 7.67.x and 7.67.x-blue branches? @bxf12315

bxf12315 · 2022-07-27T13:16:32Z

have you back ported to 7.67.x and 7.67.x-blue branches? @bxf12315

back port PR in here https://github.com/kiegroup/droolsjbpm-integration/pull/2807/commits

… 2 MB (#2648)

bxf12315 requested review from pefernan and prashuts November 10, 2021 08:52

bxf12315 force-pushed the JBPM-9942 branch from 0fbdf3c to 3cde2db Compare November 10, 2021 09:18

nmirasch reviewed Dec 20, 2021

View reviewed changes

pefernan requested a review from jstastny-cz December 20, 2021 09:06

pefernan previously requested changes Dec 20, 2021

View reviewed changes

jstastny-cz removed the request for review from prashuts January 4, 2022 10:15

bxf12315 force-pushed the JBPM-9942 branch from 3cde2db to 19551a4 Compare February 11, 2022 14:31

mareknovotny requested a review from pefernan May 10, 2022 13:09

pefernan requested changes May 12, 2022

View reviewed changes

...s/kie-server-services-jbpm-ui/src/main/resources/form-templates-providers/js/kieserver-ui.js Outdated Show resolved Hide resolved

bxf12315 force-pushed the JBPM-9942 branch from 19551a4 to 0f3c0ea Compare May 13, 2022 09:13

mareknovotny requested a review from pefernan May 16, 2022 07:48

pefernan approved these changes May 16, 2022

View reviewed changes

jstastny-cz reviewed May 18, 2022

View reviewed changes

...s/kie-server-services-jbpm-ui/src/main/resources/form-templates-providers/js/kieserver-ui.js Outdated Show resolved Hide resolved

...s/kie-server-services-jbpm-ui/src/main/resources/form-templates-providers/js/kieserver-ui.js Outdated Show resolved Hide resolved

bxf12315 force-pushed the JBPM-9942 branch from 342fe11 to a4c1774 Compare May 18, 2022 09:21

pefernan self-requested a review May 18, 2022 10:00

bxf12315 force-pushed the JBPM-9942 branch 3 times, most recently from 6e062eb to ad15223 Compare May 18, 2022 15:24

JBPM-9942 When try to attach a document the file can not greater than…

9e72f91

… 2 MB

bxf12315 force-pushed the JBPM-9942 branch from ad15223 to 9e72f91 Compare May 25, 2022 15:01

pefernan approved these changes May 25, 2022

View reviewed changes

jstastny-cz approved these changes May 26, 2022

View reviewed changes

mareknovotny merged commit 8be4b0a into kiegroup:main May 28, 2022

bxf12315 added a commit to Cory-jbpm/droolsjbpm-integration that referenced this pull request Jun 14, 2022

JBPM-9942 When try to attach a document the file can not greater than…

4440d8d

… 2 MB (kiegroup#2648)

bxf12315 added a commit to Cory-jbpm/droolsjbpm-integration that referenced this pull request Jul 22, 2022

JBPM-9942 When try to attach a document the file can not greater than…

1ffdd9c

… 2 MB (kiegroup#2648)

nmirasch pushed a commit that referenced this pull request Jul 27, 2022

JBPM-9942 When try to attach a document the file can not greater than…

ffd7e6f

… 2 MB (#2648)

nmirasch pushed a commit that referenced this pull request Jul 27, 2022

JBPM-9942 When try to attach a document the file can not greater than…

80e3d52

… 2 MB (#2648)

JBPM-9942 When try to attach a document the file can not greater tha… #2648

JBPM-9942 When try to attach a document the file can not greater tha… #2648

Conversation

bxf12315 commented Nov 10, 2021

bxf12315 commented Nov 10, 2021

sonarcloud bot commented Nov 10, 2021

prashuts commented Nov 16, 2021

bxf12315 commented Dec 13, 2021

nmirasch Dec 20, 2021

Choose a reason for hiding this comment

bxf12315 Dec 20, 2021

Choose a reason for hiding this comment

pefernan Dec 20, 2021

Choose a reason for hiding this comment

jstastny-cz Jan 4, 2022

Choose a reason for hiding this comment

nmirasch commented Dec 20, 2021

pefernan commented Dec 20, 2021

pefernan left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Feb 11, 2022

bxf12315 commented Mar 11, 2022

bxf12315 commented Mar 11, 2022

mareknovotny commented May 11, 2022

mareknovotny commented May 12, 2022

pefernan left a comment

Choose a reason for hiding this comment

mareknovotny commented May 13, 2022

jstastny-cz commented May 16, 2022

jstastny-cz commented May 16, 2022

jstastny-cz commented May 16, 2022

mareknovotny commented May 16, 2022

mareknovotny commented May 16, 2022

mareknovotny commented May 16, 2022

jstastny-cz commented May 17, 2022

jstastny-cz commented May 17, 2022

bxf12315 commented May 17, 2022

bxf12315 commented May 17, 2022

mareknovotny commented May 18, 2022 • edited

jstastny-cz commented May 25, 2022

jstastny-cz commented May 25, 2022

pefernan left a comment

Choose a reason for hiding this comment

sonarcloud bot commented May 25, 2022

jstastny-cz left a comment

Choose a reason for hiding this comment

mareknovotny commented Jul 27, 2022

bxf12315 commented Jul 27, 2022

mareknovotny commented May 18, 2022 •

edited