Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBPM-10077 Field with LocalDateTime is forcing to enter value even th… #2780

Merged
merged 1 commit into from May 16, 2022

Conversation

bxf12315
Copy link
Member

…ough its not marked mandatory

Thank you for submitting this pull request

JIRA: (please edit the JIRA link if it exists)

https://issues.redhat.com/browse/JBPM-10077

referenced Pull Requests: (please edit the URLs of referenced pullrequests if they exist)

  • paste the link(s) from GitHub here
  • link 2
  • link 3 etc.
How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • a pull request please add comment: Jenkins retest this

  • a full downstream build please add comment: Jenkins run fdb

  • a compile downstream build please add comment: Jenkins run cdb

  • a full production downstream build please add comment: Jenkins execute product fdb

  • an upstream build please add comment: Jenkins run upstream

@bxf12315
Copy link
Member Author

Jenkins run fdb

@bxf12315
Copy link
Member Author

Jenkins run fdb

@bxf12315
Copy link
Member Author

Jenkins retest this

Copy link
Member

@pefernan pefernan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bxf12315 the change works well in process forms but in task forms the function isn't added into the code. I'd suggest moving the function declaration to kieserver-ui.js instead of programatically adding it into the template.

@mareknovotny
Copy link
Member

jenkins retest this please

@bxf12315
Copy link
Member Author

Jenkins run fdb

Copy link
Contributor

@nmirasch nmirasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments regarding the js code. I verified this code fixes the reported issue.

@bxf12315
Copy link
Member Author

Jenkins run fdb

@sonarcloud
Copy link

sonarcloud bot commented May 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@bxf12315
Copy link
Member Author

Jenkins run fdb

1 similar comment
@bxf12315
Copy link
Member Author

Jenkins run fdb

@mareknovotny
Copy link
Member

@ChughShilpa @pefernan @nmirasch is all now ok, please approve or ask for changes!

@jstastny-cz
Copy link

@mareknovotny we're summarizing and evaluating possible issues, we should have the feedback in following hours.

@jstastny-cz jstastny-cz removed their request for review May 16, 2022 13:12
Copy link

@ChughShilpa ChughShilpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the functionality. It looks fine.

@mareknovotny mareknovotny merged commit 63a81a8 into kiegroup:main May 16, 2022
bxf12315 added a commit to Cory-jbpm/droolsjbpm-integration that referenced this pull request Jun 14, 2022
bxf12315 added a commit to Cory-jbpm/droolsjbpm-integration that referenced this pull request Jul 22, 2022
nmirasch pushed a commit that referenced this pull request Jul 27, 2022
nmirasch pushed a commit that referenced this pull request Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants