New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JBPM-10071] test for WIH's abortWorkItem method should be called #2829
Conversation
Jenkins restest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor cosmetic changes, but it looks awesome as is right now. No need to change.
Nice work!
NodeInstanceList nodeInstanceList = marshaller.unmarshall(response.readEntity(String.class), NodeInstanceList.class); | ||
|
||
assertThat(response.getStatus()).isEqualTo(Response.Status.OK.getStatusCode()); | ||
nodeInstanceList.getItems().get(0).getWorkItemId(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this needed?
|
||
@Test | ||
public void testAbortWorkItemWithCustomImplementation() { | ||
Map<String, Object> valuesMap = new HashMap<String, Object>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Map<String, Object> valuesMap = new HashMap<String, Object>(); | |
Map<String, Object> valuesMap = new HashMap<>(); |
jenkins retest this please |
Jenkins retest this |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@mareknovotny this is ready to merge |
JIRA: JBPM-10071
How to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.
How to retest this PR or trigger a specific build:
a pull request please add comment: Jenkins retest this
a full downstream build please add comment: Jenkins run fdb
a compile downstream build please add comment: Jenkins run cdb
a full production downstream build please add comment: Jenkins execute product fdb
an upstream build please add comment: Jenkins run upstream