[JBPM-10127] Performance downgrade in cluster extension #2868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elguardian
force-pushed
the
JBPM-10127
branch
2 times, most recently
from
330283e
to
ebf9dd2
Compare
gmunozfe
suggested changes
Nov 2, 2022
| @@ -58,6 +55,8 @@ public class InfinispanClusterAwareService implements ClusterAwareService { | |||
| private String kieServerId; | |||
| private String kieServerLocation; | |||
|
|
|||
| private EmbeddedCacheManager cacheManager; | |||
There was a problem hiding this comment.
Could you choose another name? It's clashing with other local variables
This was referenced Nov 7, 2022
elguardian
force-pushed
the
JBPM-10127
branch
from
ebf9dd2
to
0fa9398
Compare
|
Kudos, SonarCloud Quality Gate passed! |
gmunozfe
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.redhat.com/browse/JBPM-10127