Ensure elytron is on the classpath before using it

[lampajr]

Thank you for submitting this pull request

JIRA:

• https://issues.redhat.com/browse/RHPAM-4714

referenced Pull Requests:

• [RHPAM-4714] wildfly-elytron as provided #2961

Changes performed #2961 were not enough as kieServerMatrix tests are still failing while using tomcat server:

[INFO] [talledLocalContainer] SEVERE: Exception sending context initialized event to listener instance of class [org.kie.server.remote.rest.common.Bootstrap]
[INFO] [talledLocalContainer] java.lang.NoClassDefFoundError: org/wildfly/security/auth/server/SecurityDomain
[INFO] [talledLocalContainer] 	at org.kie.server.services.impl.security.ElytronIdentityProvider.available(ElytronIdentityProvider.java:33)
[INFO] [talledLocalContainer] 	at org.kie.server.services.impl.KieServerImpl.init(KieServerImpl.java:157)
[INFO] [talledLocalContainer] 	at org.kie.server.services.impl.KieServerImpl.init(KieServerImpl.java:142)
[INFO] [talledLocalContainer] 	at org.kie.server.services.impl.KieServerLocator$KieServerLocatorHelper.<clinit>(KieServerLocator.java:25)
[INFO] [talledLocalContainer] 	at org.kie.server.services.impl.KieServerLocator.getInstance(KieServerLocator.java:32)
[INFO] [talledLocalContainer] 	at org.kie.server.remote.rest.common.Bootstrap.contextInitialized(Bootstrap.java:51)
[INFO] [talledLocalContainer] 	at org.apache.catalina.core.StandardContext.listenerStart(StandardContext.java:4682)
[INFO] [talledLocalContainer] 	at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5143)
....
[INFO] [talledLocalContainer] Caused by: java.lang.ClassNotFoundException: org.wildfly.security.auth.server.SecurityDomain
[INFO] [talledLocalContainer] 	at org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClassLoaderBase.java:1365)
[INFO] [talledLocalContainer] 	at org.apache.catalina.loader.WebappClassLoaderBase.loadClass(WebappClassLoaderBase.java:1188)
[INFO] [talledLocalContainer] 	... 47 more

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:

• a pull request please add comment: Jenkins retest this

• a full downstream build please add comment: Jenkins run fdb

• a compile downstream build please add comment: Jenkins run cdb

• a full production downstream build please add comment: Jenkins execute product fdb

• an upstream build please add comment: Jenkins run upstream

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

[sutaakar]

@lampajr Just one minor point, can you fix the bug reported by Sonarcloud?
Otherwise looks ok (didn't try to run it by myself).

[lampajr]

@sutaakar yeah I am trying to refactor it in a better way, I think I found how to do it

[lampajr]

@lampajr Just one minor point, can you fix the bug reported by Sonarcloud? Otherwise looks ok (didn't try to run it by myself).

The bug is fixed now, still low level of coverage :/

[lampajr]

Jenkins run fdb

[mareknovotny]

it seems we need to wait until we can use our installation host for node

[sutaakar]

Looks ok, though it needs to be checked in nightly jobs for all application servers after merge.

[lampajr]

@sutaakar @mareknovotny added some new unit tests trying to cover some branches c453d1f, wdyt?

Maybe they are not enough to make coverage check green so if they are not really needed I can just remove last commit :)

[sutaakar]

Looks ok for me

[lampajr]

Coverage improved a bit (from 60% to 70%) but still complaining about Refactor this method to reduce its Cognitive Complexity from 16 to the 15 allowed. I'll try to refactor again that method in order to reduce the complexity again

[mareknovotny]

i think you can run sonar with sonarlint (https://www.sonarsource.com/products/sonarlint/) also locally in your IDE if you need to check what improvements value it is ;)

[sonarcloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

71.2% Coverage
0.0% Duplication