[JBPM-8380] Remove JBPMHelper

[karlnicholas]

Updates to be pulled in tandem with kiegroup/jbpm#1477

[ghost]

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

[MarianMacik]

ok to test

[mswiderski]

@MarianMacik @elguardian guys, could you please review and approve so it can be merged?

[MarianMacik]

jenkins retest this

[krisv]

@mswiderski @MarianMacik did we check if this code still works with jBPM 6.0 and above? As we reuse this file for all versions (v5 has its own version).

[mswiderski]

I haven't tried it so not sure but what you wrote kind of scares me ... isn't that a bit of too much of code reuse

[karlnicholas]

@krisv - I don't know that I explicitly check but I considered it. Generally it looks better and the code is mostly self contained but it does depend PersistenceUtils. I don't know if that class existed in 6.0.

[MarianMacik]

This was only done on master, so I believe it should be OK for other versions.