This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
Ensure MavenSettings is reinitialised after tests. Switch to use of static property name #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mariofusco @psiroky Care to review? |
| oldSettingsXmlPath ); | ||
| } else { | ||
| System.clearProperty( MavenSettings.CUSTOM_SETTINGS_PROPERTY ); |
There was a problem hiding this comment.
This (the 6 lines above) seems to be repeating several times in the tests. Would it make sense to move to a method?
|
@manstis looks good, I just made a minor comment about avoiding small duplication. |
…tatic property name.
manstis
force-pushed
the
ResetMavenSettings
branch
from
15e3723
to
de5145d
Compare
|
@psiroky Updated. Please review (again). |
|
Nice, thanks @manstis. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion on IRC and this updated tests accordingly.