AF-593: Migrate Data Modeller to AppFormer #519
Conversation
|
@wmedvede I see you have lots of commits in guvnor lately. Care to review this? All changes are to dependencies and imports. |
There was a problem hiding this comment.
Hi @mbarkley looks good, just one note.
As you said the change is mostly some package name changes.
In particular "org.uberfire.commons.validation" was changed to "org.kie.soup.commons.validation"
This is fine, but see that the
org.uberfire.commons.validation.PortablePreconditions class currently belongs to the gwt module
<inherits name="org.uberfire.commons.UberfireCommons"/> and is a gwt compiled class.
And the following gwt modules in guvnor are inheriting the org.uberfire.commons.UberfireCommons module.
So I belive a rename like the one below might be missing on this files:
<inherits name="org.uberfire.commons.UberfireCommons"/> to
<inherits name="org.kie.soup.commons.SoupCommons???"/> ?
See that this case might also happen in other projects like kie-wb-commons, drools-wb, etc, that are using the PortablePreconditions in client side.
|
@wmedvede Should be fine as the KieSoupCommons module is inherited in UberfireCommons. I've only added the dependency in the POM files because of our Maven enforcer rules. |
|
@mbarkley ok, in this case just discard my long comment :) |
|
@wmedvede Hehe, thanks for the review! |
|
Jenkins, please retest this. |
No description provided.