Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

RHBPMS-5008: [Security management] Disabled assets can be edited #683

Merged
merged 1 commit into from Oct 17, 2017
Merged

RHBPMS-5008: [Security management] Disabled assets can be edited #683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 5 additions & 4 deletions jbpm-designer-client/src/main/java/org/jbpm/designer/client/DesignerPresenter.java
View file
Open in desktop
Expand Up @@ -144,14 +144,15 @@ protected void makeMenuBar() {
.addSave(versionRecordManager.newSaveMenuItem(new Command() {
@Override
public void execute() {
onSave();
saveAction();
}
}))
.addCopy(versionRecordManager.getCurrentPath(),
fileNameValidator)
assetUpdateValidator)
.addRename(versionRecordManager.getPathToLatest(),
fileNameValidator)
.addDelete(versionRecordManager.getPathToLatest());
assetUpdateValidator)
.addDelete(versionRecordManager.getPathToLatest(),
assetUpdateValidator);
}

fileMenuBuilder
Expand Down
16 changes: 9 additions & 7 deletions jbpm-designer-client/src/test/java/org/jbpm/designer/client/DesignerPresenterTest.java
View file
Open in desktop
Expand Up @@ -28,14 +28,14 @@
import org.junit.Test;
import org.junit.runner.RunWith;
import org.kie.workbench.common.widgets.client.menu.FileMenuBuilderImpl;
import org.kie.workbench.common.widgets.metadata.client.validation.AssetUpdateValidator;
import org.mockito.InjectMocks;
import org.mockito.Mock;
import org.mockito.Spy;
import org.mockito.runners.MockitoJUnitRunner;
import org.uberfire.backend.vfs.Path;
import org.uberfire.ext.editor.commons.client.history.VersionRecordManager;
import org.uberfire.ext.editor.commons.client.menu.BasicFileMenuBuilder;
import org.uberfire.ext.editor.commons.client.validation.DefaultFileNameValidator;
import org.uberfire.workbench.model.menu.MenuItem;

import static org.junit.Assert.assertEquals;
Expand Down Expand Up @@ -130,10 +130,11 @@ public void testMakeMenuBar() {

verify(fileMenuBuilder).addSave(any(MenuItem.class));
verify(fileMenuBuilder).addCopy(any(Path.class),
any(DefaultFileNameValidator.class));
any(AssetUpdateValidator.class));
verify(fileMenuBuilder).addRename(any(Path.class),
any(DefaultFileNameValidator.class));
verify(fileMenuBuilder).addDelete(any(Path.class));
any(AssetUpdateValidator.class));
verify(fileMenuBuilder).addDelete(any(Path.class),
any(AssetUpdateValidator.class));
}

@Test
Expand All @@ -147,11 +148,12 @@ public void testMakeMenuBarWithoutUpdateProjectPermission() {
never()).addSave(any(MenuItem.class));
verify(fileMenuBuilder,
never()).addCopy(any(Path.class),
any(DefaultFileNameValidator.class));
any(AssetUpdateValidator.class));
verify(fileMenuBuilder,
never()).addRename(any(Path.class),
any(DefaultFileNameValidator.class));
any(AssetUpdateValidator.class));
verify(fileMenuBuilder,
never()).addDelete(any(Path.class));
never()).addDelete(any(Path.class),
any(AssetUpdateValidator.class));
}
}