JBPM-7913 - Create pastebin workitem #76
Conversation
|
pastebin workitem (can create a new pastebin) |
tsurdilo
force-pushed
the
pastebin
branch
2 times, most recently
from
2b72d1f
to
7856477
Compare
| public class CreatePastebinWorkitemHandler extends AbstractLogOrThrowWorkItemHandler { | ||
|
|
||
| private String develKey; | ||
| private PastebinPaste pastebin; |
There was a problem hiding this comment.
why do we need to have pastebin as field? It makes it not really thread safe...
| workItem); | ||
|
|
||
| String title = (String) workItem.getParameter("Title"); | ||
| Document contentDoc = (Document) workItem.getParameter("Content"); |
There was a problem hiding this comment.
I guess simple text would make sense too, maybe have to arguments Content and ContentDoc or something like that, wdyt?
|
|
||
| <artifactId>pastebin-workitem</artifactId> | ||
| <name>Pastebin</name> | ||
| <description>Create new or get existing pastes from Pastebin</description> |
There was a problem hiding this comment.
I couldn't find the work item handler to get existing pastes... is this still planned to be implemented?
There was a problem hiding this comment.
Wanted to and would be easy but for scraping existing padtebin makes you buy the pro version which costs money, so i deferred it for now.can add
|
@mswiderski updated + added get existing pastebin handler |
|
Jenkins retest please |
| String author = (String) workItem.getParameter("Author"); | ||
|
|
||
| // for testing | ||
| PastebinPaste testPastebin = (PastebinPaste) workItem.getParameter("TestPastebin"); |
There was a problem hiding this comment.
maybe replace this (and the below if else) with following
PastebinPaste pastebin = (PastebinPaste) workItem.getParameter("Pastebin");
if (pastebin == null) {
pastebin = new PastebinPaste();
}
that way it's not really test specific as users can simply add their pastebins manually. Moreover you can even skip all other parameters if the pastebin is given...
|
|
||
| String pastebinKey = (String) workItem.getParameter("PastebinKey"); | ||
| // for testing | ||
| PastebinLink testPastebinLink = (PastebinLink) workItem.getParameter("TestPastebinLink"); |
There was a problem hiding this comment.
similar here, allow to provide PastebinLink as work item param so it won't be test specific
|
@mswiderski updated - thanks! |
|
rebased and updated pom to 7.15.0-SNAPSHOT. should build fine now. |
|
Jenkins retest please |
1 similar comment
|
Jenkins retest please |
No description provided.