JBPM-5891 - Process validation should not trigger on empty package na…

…me (#814)
kiegroup · Apr 14, 2017 · 3902939 · 3902939
1 parent af4f06b
commit 3902939
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 8 deletions.
diff --git a/jbpm-flow-builder/src/test/java/org/jbpm/integrationtests/ProcessFlowControlTest.java b/jbpm-flow-builder/src/test/java/org/jbpm/integrationtests/ProcessFlowControlTest.java
@@ -358,10 +358,10 @@ public void testRuleFlowActionDialects() throws Exception {
     }
 
     @Test
-    public void testLoadingRuleFlowInPackage7() throws Exception {
-        // loading a ruleflow with errors
+    public void testLoadingRuleFlowNoPackageName() throws Exception {
+        // loading a ruleflow with errors (null package name cause 3 errors)
         builder.addRuleFlow( new InputStreamReader( getClass().getResourceAsStream( "error_ruleflow.rfm" ) ) );
-        assertEquals( 1,
+        assertEquals( 3,
                       builder.getErrors().getErrors().length );
     }
 

diff --git a/jbpm-flow/src/main/java/org/jbpm/ruleflow/core/validation/RuleFlowProcessValidator.java b/jbpm-flow/src/main/java/org/jbpm/ruleflow/core/validation/RuleFlowProcessValidator.java
@@ -113,11 +113,6 @@ public ProcessValidationError[] validateProcess(final RuleFlowProcess process) {
                 "Process has no id."));
         }
 
-        if ( process.getPackageName() == null || "".equals( process.getPackageName() ) ) {
-            errors.add(new ProcessValidationErrorImpl(process,
-                "Process has no package name."));
-        }
-
         // check start node of process
         if ( process.getStartNodes().isEmpty() && !process.isDynamic()) {
             errors.add(new ProcessValidationErrorImpl(process,

diff --git a/jbpm-flow/src/test/java/org/jbpm/ruleflow/core/validation/RuleFlowProcessValidatorTest.java b/jbpm-flow/src/test/java/org/jbpm/ruleflow/core/validation/RuleFlowProcessValidatorTest.java
@@ -125,4 +125,27 @@ public void testDynamicNodeValidationInDynamicProcess() throws Exception {
         assertEquals("Node 'MyDynamicNode' [1] Dynamic has no completion condition set", errors2[0].getMessage());
 
     }
+
+    @Test
+    public void testEmptyPackageName() throws Exception {
+        RuleFlowProcess process = new RuleFlowProcess();
+        process.setId("org.drools.core.process");
+        process.setName("Empty Package Name Process");
+        process.setPackageName("");
+        process.setDynamic(true);
+
+        ProcessValidationError[] errors = validator.validateProcess(process);
+        assertNotNull(errors);
+    }
+
+    @Test
+    public void testNoPackageName() throws Exception {
+        RuleFlowProcess process = new RuleFlowProcess();
+        process.setId("org.drools.core.process");
+        process.setName("No Package Name Process");
+        process.setDynamic(true);
+
+        ProcessValidationError[] errors = validator.validateProcess(process);
+        assertNotNull(errors);
+    }
 }