fix findbugs warning 'No relationship between generic parameter and m…

…ethod argument'
kiegroup · Jun 30, 2015 · a739d16 · a739d16
1 parent 4392e83
commit a739d16
Show file tree

Hide file tree

Showing 5 changed files with 111 additions and 122 deletions.
diff --git a/jbpm-flow/src/main/java/org/jbpm/workflow/core/node/StateNode.java b/jbpm-flow/src/main/java/org/jbpm/workflow/core/node/StateNode.java
@@ -52,8 +52,8 @@ public void addConstraint(ConnectionRef connectionRef, Constraint constraint) {
         constraints.put(connectionRef, constraint);
     }
 
-    public Constraint getConstraint(String name){
-        return constraints.get(name);
+    public Constraint getConstraint(ConnectionRef connectionRef){
+        return constraints.get(connectionRef);
     }
 
     public Map<ConnectionRef, Constraint> getConstraints(){

diff --git a/jbpm-flow/src/main/java/org/jbpm/workflow/instance/WorkflowProcessInstanceUpgrader.java b/jbpm-flow/src/main/java/org/jbpm/workflow/instance/WorkflowProcessInstanceUpgrader.java
@@ -18,6 +18,7 @@
 
 import java.util.HashMap;
 import java.util.Map;
+import java.util.Stack;
 
 import org.drools.core.common.InternalKnowledgeRuntime;
 import org.jbpm.ruleflow.core.RuleFlowProcess;
@@ -31,7 +32,6 @@
 import org.kie.api.definition.process.WorkflowProcess;
 import org.kie.api.runtime.KieRuntime;
 import org.kie.api.runtime.process.NodeInstance;
-import java.util.Stack;
 
 public class WorkflowProcessInstanceUpgrader {
 
@@ -93,7 +93,7 @@ public static void upgradeProcessInstanceByNodeNames(
             if (processFrom instanceof WorkflowProcess) {
                 from = getNodeId(((WorkflowProcess) processFrom).getNodes(), entry.getKey(), true);
             } else if (processFrom instanceof RuleFlowProcess) {
-                from = getNodeId(((RuleFlowProcessInstance) processFrom).getWorkflowProcess().getNodes(), entry.getKey(), true);
+                from = getNodeId(((RuleFlowProcess) processFrom).getNodes(), entry.getKey(), true);
             } else if (processFrom != null) {
                 throw new IllegalArgumentException("Suported processes are WorkflowProcess and RuleFlowProcess, it was:" + processFrom.getClass());
             } else {