JBPM-6487 JBPM tests stabilisation PR5 #1068
Conversation
dcihak
commented
Nov 13, 2017
dcihak
commented
- null check added becauseTestWorkItemHandler.getWorkItem can possibly return null,
- null value comparison,
- using of junit replaced by assertJ
- null check added becauseTestWorkItemHandler.getWorkItem can possibly return null, - null value comparison, - using of junit replaced by assertJ
dcihak
changed the title
|
Ready to be merged |
|
Whats' the reason to use verbose Assertions.assertThat everywhere and not use static import and just use "assertThat" instead ? |
|
@dcihak can you import it statically when there is not a conflict with jUnit assertions? Thanks. |
| @@ -245,8 +245,7 @@ public void testSignalIntermediateThrow() throws Exception { | |||
| params.put("x", "MyValue"); | |||
| ProcessInstance processInstance = ksession.startProcess( | |||
| "SignalIntermediateEvent", params); | |||
| assertEquals(ProcessInstance.STATE_COMPLETED, | |||
| processInstance.getState()); | |||
| Assertions.assertThat(processInstance.getState()).isEqualTo(ProcessInstance.STATE_COMPLETED); | |||
There was a problem hiding this comment.
I think in this class it is possible.
* static import for org.assertj.core.api.Assertions added into IntermediateEventTest * AbstractBaseTest and JbpmJUnitBaseTestCase must not extend org.junit.Assert, static import of org.junit.Assert.* added instead to the ancestors*
|
Static import for org.assertj.core.api.Assertions added to IntermediateEventTest, AbstractBaseTest and JbpmJUnitBaseTestCase must not extend org.junit.Assert, static import of org.junit.Assert.* added to the ancestors |
|
jenkins retest this |
1 similar comment
|
jenkins retest this |
|
Ready to be merged. |
There was a problem hiding this comment.
@tsurdilo so basically IDE didn't recommend the static import because it would have conflicted with other assertThat methods which were in the parent Assert class. Now it is OK since we don't extend jUnit in jbpm repo.
|
@MarianMacik looks good now +1 |
|
I think we can merge this. |
* JBPM-6487: - null check added becauseTestWorkItemHandler.getWorkItem can possibly return null, - null value comparison, - using of junit replaced by assertJ * JBPM-6487: * static import for org.assertj.core.api.Assertions added into IntermediateEventTest * AbstractBaseTest and JbpmJUnitBaseTestCase must not extend org.junit.Assert, static import of org.junit.Assert.* added instead to the ancestors*
