RHBA-365 - Pagination displays incorrect amount of tasks when custom … #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsurdilo
reviewed
Jan 9, 2018
| @@ -60,7 +68,18 @@ public void preprocess(DataSetLookup lookup) { | |||
| filter.addFilterColumn(columnFilter); | |||
| lookup.addOperation(filter); | |||
| } | |||
|
|
|||
| if (lookup.getLastGroupOp() == null) { | |||
There was a problem hiding this comment.
Could be extracted in util method maybe cause seems to be reusable logic?
| @@ -69,7 +77,19 @@ public void preprocess(DataSetLookup lookup) { | |||
| filter.addFilterColumn(columnFilter); | |||
| lookup.addOperation(filter); | |||
| } | |||
|
|
|||
|
|
|||
| if (lookup.getLastGroupOp() == null) { | |||
| @@ -65,5 +73,17 @@ public void preprocess(DataSetLookup lookup) { | |||
| filter.addFilterColumn(columnFilter); | |||
| lookup.addOperation(filter); | |||
| } | |||
| if (lookup.getLastGroupOp() == null) { | |||
|
Jenkins execute full downstream build |
|
@tsurdilo fixed the duplication |
tsurdilo
approved these changes
Jan 10, 2018
MarianMacik
approved these changes
Jan 10, 2018
…advanced query returns duplicate records
|
Jenkins execute full downstream build |
mswiderski
added a commit
to mswiderski/jbpm
that referenced
this pull request
Jan 18, 2018
…om advanced query returns duplicate records (kiegroup#1110)
mswiderski
added a commit
that referenced
this pull request
Jan 31, 2018
…om advanced query returns duplicate records (#1110)
hxf0801
pushed a commit
to hxf0801/jbpm
that referenced
this pull request
Apr 27, 2018
…advanced query returns duplicate records (kiegroup#1110)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…advanced query returns duplicate records