[6.5.x] RHBPMS-5154: Test case for DisabledFollowOnLockOracle10gDialect #1193
Conversation
|
Jenkins retest this |
mswiderski
changed the title
| public class ExecutorQueryServiceTest { | ||
|
|
||
| protected ExecutorService executorService; | ||
| private static final int THREADS = 2; |
There was a problem hiding this comment.
Just one question. Are 2 threads enough? I personally would increase it to at least 4. But just a suggestion :) Wdyt @mswiderski.
| try { | ||
| request = ctx.find(org.jbpm.executor.entities.RequestInfo.class, ((Number)lockedRequest[0]).longValue()); | ||
| } catch(NumberFormatException nfe) { | ||
| } |
There was a problem hiding this comment.
Shouldn't we include there at least a warning log message? Empty catch blocks are really not a good practice even if we know that there is a very little chance of throwing that exception.
|
@MarianMacik do you still insist on your comments before merging, right? |
|
@mareknovotny Well, at least I would like to hear opinion on that from @martinweiler. Wdyt? |
|
@MarianMacik - 2 threads are ok to reproduce the issue. For the NFE, I have added some logging. |
| * -Dmaven.hibernate.dialect=org.hibernate.dialect.Oracle10gDialect | ||
| * | ||
| * // the test should be successful using the custom dialect | ||
| * -Dmaven.hibernate.dialect=org.jbpm.persistence.jpa.hibernate.DisabledFollowOnLockOracle10gDialect |
There was a problem hiding this comment.
Thanks, @martinweiler. Just one last question - the issue was with the DisabledFollowOnLockOracle10gDialect not working properly, but Oracle10gDialect working as intended? Because the JavaDoc says that it should fail with org.hibernate.dialect.Oracle10gDialect. Is this still true?
There was a problem hiding this comment.
org.hibernate.dialect.Oracle10gDialect is not working as intended, as it does not lock a job properly. You will see 'HHH000444: Encountered request for locking however dialect reports that database prefers locking be done in a separate select' WARN messages, and the test will fail as the job is executed on both threads.
There was a problem hiding this comment.
Then I see one issue with the test. When we run full certification matrix of jbpm, we use Oracle10gDialect which is the first to be supported afaik. Is this DisabledFollowOnLockOracle10gDialect supported too? Anyway, this means that our certification matrix will fail with the Oracle database. So do we still have a bug with default Oracle10gDialect or this use case is not supported with the default Oracle10gDialect?
There was a problem hiding this comment.
I guess then we need to disable this test in the default test suite. See https://bugzilla.redhat.com/show_bug.cgi?id=1234592 as well as https://hibernate.atlassian.net/browse/HHH-1168?focusedCommentId=48846 for background information on why this custom dialect was necessary to begin with.
There was a problem hiding this comment.
@martinweiler Are you going to disable the test in this PR then?
No description provided.