Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename profiles after wildfly14 migration #1366

Merged
merged 1 commit into from Nov 6, 2018
Merged

Rename profiles after wildfly14 migration #1366

merged 1 commit into from Nov 6, 2018

Conversation

jhrcek
Copy link

@jhrcek jhrcek commented Nov 5, 2018 •
edited

This was referenced Nov 5, 2018
Merged
Merged
Merged
Merged
MarianMacik
MarianMacik approved these changes Nov 5, 2018
View reviewed changes
Copy link
Member

@MarianMacik MarianMacik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jhrcek!

@jhrcek
Copy link
Author

jhrcek commented Nov 5, 2018

rerunning tests after profiles have been renamed in jenkins job config
jenkins retest this

@jhrcek
Copy link
Author

jhrcek commented Nov 6, 2018 •
edited

@mbiarnes It's green after profile renaming and PR job config update. And I double-checked that the same amount of tests was executed as before the change, so no coverage was accidentally lost due to misconfiguration. Please merge this before upgrading to 7.15.0. Note this can be merged independently even if other PRs in this ensemble aren't merged

CC @MarianMacik be aware that the wildfly profiles have been renamed

@mbiarnes mbiarnes merged commit 9179333 into kiegroup:master Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarianMacik MarianMacik MarianMacik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jhrcek @MarianMacik @mbiarnes