Refactoring of WorkItemNodeInstance for extensibility #1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… WorkItemNodeInstance to allow inheriting classes to change the parameter mapping behaviour and removed the unnecessary type casting
|
Can one of the admins verify this PR? Comment with 'ok to test' to start the build. |
… protected for extendability
|
I've added an extra commit to do something similar with the RuleSetNodeInstance |
|
ok to test |
mswiderski
approved these changes
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have refactored (no logic changed) the WorkItemNodeInstance class to allow redefining the data mapping logic when inheriting from the class. No behavior was changed.
Basically this let us extend the class and customize how we do the data mapping for the inputs/outputs.
Let me know if you have questions!
Thanks