Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.26.x] [JBPM-8694] ConditionalEvent isn't triggered when process id contains hyphen (#1525) #1543

Merged
merged 1 commit into from Oct 28, 2019
Merged

[7.26.x] [JBPM-8694] ConditionalEvent isn't triggered when process id contains hyphen (#1525) #1543

merged 1 commit into from Oct 28, 2019

Conversation

elguardian
Copy link
Member

  • [JBPM-8694] ConditionalEvent isn't triggered when process id contains hyphen
  • Unit test
  • [JBPM-8694] [JBPM-8694] ConditionalEvent isn't triggered when process id contains hyphen

@elguardian
[JBPM-8694] ConditionalEvent isn't triggered when process id contains…
da57c28 
… hyphen (kiegroup#1525)

* [JBPM-8694] ConditionalEvent isn't triggered when process id contains hyphen
- Unit test

* [JBPM-8694] [JBPM-8694] ConditionalEvent isn't triggered when process id contains hyphen
@elguardian elguardian changed the title [JBPM-8694] ConditionalEvent isn't triggered when process id contains hyphen (#1525) [7.26.x] [JBPM-8694] ConditionalEvent isn't triggered when process id contains hyphen (#1525) Oct 1, 2019
@MarianMacik
Copy link
Member

jenkins retest this

@elguardian
Copy link
Member Author

Jenkins retest this please.

MarianMacik
MarianMacik approved these changes Oct 25, 2019
View reviewed changes
Copy link
Member

@MarianMacik MarianMacik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mareknovotny
Copy link
Member

failing org.jbpm.services.task.identity.LDAPUserInfoImplTest.testGroupsOneLevelScopeRolesContext

Can you look at why it fails?

@elguardian
Copy link
Member Author

@mareknovotny sry for the late response... that is environment due to some other test binding the port already in used.

@krisv krisv merged commit 4d4b4d9 into kiegroup:7.26.x Oct 28, 2019
@elguardian elguardian deleted the JBPM-8694-7.26.x branch October 28, 2019 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarianMacik MarianMacik MarianMacik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@elguardian @MarianMacik @mareknovotny @krisv