[JBPM-8896] NPE during Process Migration when Boundary Timer is fired but UserTask not completed

[elguardian]

self remove timer if there is no next boundary event in human task

[elguardian]

this is ok to test.

[mswiderski]

the fix looks proper to me, just to investigate why the build failed.

[elguardian]

Jenkins restest this please.

[gmunozfe]

Both tests (org.jbpm.integrationtests.ProcessStateTest.testTimerState & org.jbpm.integrationtests.ProcessTimerTest.testOnEntryTimerExecutedMultipleTimes) are failing because the timer is removed though it's expected to be triggered more times, due to their period is not zero.

Maybe it can be added this condition to remove only timers without defined period:
if (handler.getNext() == null && timerInstance.getPeriod() == 0L)

[elguardian]

Failure unrelated.
Jenkins retest this please.

[gmunozfe]

Looks good to me, just a minor comment in case you want to achieve it.

[gmunozfe]

@elguardian I've created a test with Quartz timers and springboot, and it's failing because jobHandler is null, so timer is not removed

droolsjbpm-integration#1980

[gmunozfe]

It seems droolsjbpm-integration test with Quartz timers is working with this new commit. Thanks @elguardian !

[gmunozfe]

jenkins retest this

[sonarcloud]

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

0.0% Coverage
0.0% Duplication

[gmunozfe]

This is ok to merge

[elguardian]

@kiegroup/gatekeepers can you merge ?