[JBPM-9002] no catching timer for parallel task or subprocess #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
elguardian
force-pushed
the
JBPM-9002
branch
3 times, most recently
from
c21f24b
to
db9d118
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
gmunozfe
reviewed
Mar 31, 2021
There was a problem hiding this comment.
There's a suspect scenario: when boundary timer is triggered and cancels activity (in the test, the workitem is aborted), it seems like both branches are activated. This reproducer test is valid for checking it:
https://github.com/elguardian/jbpm/compare/JBPM-9002...gmunozfe:JBPM-9002_cancelIssue?expand=1
jbpm-bpmn2/src/test/java/org/jbpm/bpmn2/objects/TestWorkItemHandler.java
Show resolved
Hide resolved
jbpm-bpmn2/src/test/java/org/jbpm/bpmn2/objects/TestWorkItemHandler.java
Show resolved
Hide resolved
jbpm-bpmn2/src/test/java/org/jbpm/bpmn2/IntermediateEventTest.java
Outdated
Show resolved
Hide resolved
...-util/src/main/java/org/jbpm/test/listener/process/DefaultCountDownProcessEventListener.java
Show resolved
Hide resolved
jbpm-flow/src/main/java/org/jbpm/workflow/instance/node/ForEachNodeInstance.java
Outdated
Show resolved
Hide resolved
gmunozfe
approved these changes
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
register boundary events for multiple instance loop.