Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JBPM-9072 single test #1617

Closed
wants to merge 1 commit into from
Closed

JBPM-9072 single test #1617

wants to merge 1 commit into from

Conversation

hasys
Copy link
Member

@hasys hasys commented Mar 24, 2020

Hi @elguardian, @MarianMacik,

I migrated one unit test from https://github.com/kiegroup/kogito-runtimes/pull/314/files#diff-15fa3183e6865094973de2150bbc3b78R1862 to be sure that it is not implemented in jbpm (non-Kogito). This PR can be used as base for future test migration / implementation.

Thank you!

@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@elguardian
Copy link
Member

@hasys I am bit lost with this one... what do you intent ? you said " to be sure that it is not implemented in jbpm" so this feature should not be in jbpm right ? then why this PR ¿?

@hasys
Copy link
Member Author

hasys commented Mar 25, 2020

Hi @elguardian,

sorry for confusion. I mean this feature is implemented in Kogito runtime, and I expected it to work in Business Central as well. So I started to test it in Business Central but it didn't work. But I wasn't sure is it because of issues in our BPMN Designer or in the engine, so I ported this test from Kogito to check that issue is in jbpm engine.

Since test if failing right in the place where this feature is tested I assume that test is correct and feature is not implemented. So you can use this PR as starting point to port all other tests from Kogito and than implement it in jbpm engine.

Hope it makes more sense, thank you @elguardian!

@gmunozfe
Copy link
Member

@hasys probably it could be a "draft pull request" till implementation is completed

@hasys
Copy link
Member Author

hasys commented Mar 25, 2020

@gmunozfe I am not an assignee, I just shared my findings. Feel free to close this PR if it is not needed. Next time will open a draft instead, good point.

Thank you!

@elguardian elguardian closed this Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants