Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JBPM-9249] Process upgrade fails in RHPAM 7.7 if process instance ha… #1703

Merged
merged 3 commits into from Jul 28, 2020
Merged

[JBPM-9249] Process upgrade fails in RHPAM 7.7 if process instance ha… #1703

merged 3 commits into from Jul 28, 2020

Conversation

abhijithumbe
Copy link
Contributor

…s active timer and its migrated from BPMS 6.4 release

@abhijithumbe
[JBPM-9249] Process upgrade fails in RHPAM 7.7 if process instance ha…
840b4d7 
…s active timer and its migrated from BPMS 6.4 release
@kie-ci
Copy link

kie-ci commented Jul 21, 2020

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

9 similar comments
@kie-ci
Copy link

kie-ci commented Jul 21, 2020

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@kie-ci
Copy link

kie-ci commented Jul 21, 2020

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@kie-ci
Copy link

kie-ci commented Jul 21, 2020

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@kie-ci
Copy link

kie-ci commented Jul 21, 2020

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@kie-ci
Copy link

kie-ci commented Jul 21, 2020

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@kie-ci
Copy link

kie-ci commented Jul 21, 2020

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@kie-ci
Copy link

kie-ci commented Jul 21, 2020

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@kie-ci
Copy link

kie-ci commented Jul 21, 2020

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@kie-ci
Copy link

kie-ci commented Jul 21, 2020

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@gmunozfe
Copy link
Member

jenkins retest this please

gmunozfe
gmunozfe reviewed Jul 22, 2020
View reviewed changes
Copy link
Member

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor comments regarding format and reporting.
Adding a test would be also useful to cover this scenario.
Thanks for your contribution @abhijithumbe!

...-runtime-manager/src/main/java/org/jbpm/runtime/manager/impl/migration/MigrationManager.java Outdated Show resolved Hide resolved
...-runtime-manager/src/main/java/org/jbpm/runtime/manager/impl/migration/MigrationManager.java Outdated Show resolved Hide resolved
abhijithumbe and others added 2 commits July 22, 2020 15:23
@abhijithumbe @gmunozfe
Update jbpm-runtime-manager/src/main/java/org/jbpm/runtime/manager/im…
49936cd 
…pl/migration/MigrationManager.java

Co-authored-by: Gonzalo Muñoz <gmunozfe@redhat.com>
@abhijithumbe @gmunozfe
Update jbpm-runtime-manager/src/main/java/org/jbpm/runtime/manager/im…
3f8d405 
…pl/migration/MigrationManager.java

Co-authored-by: Gonzalo Muñoz <gmunozfe@redhat.com>
@abhijithumbe
Copy link
Contributor Author

@gmunozfe this issue occurs only when process instance is migrated from BPMS 6.4 release so its bit difficult to cover this scenario in a test. Any thoughts about how can we cover this scenario in test

@gmunozfe
Copy link
Member

jenkins retest this please

@sonarcloud
Copy link

sonarcloud bot commented Jul 24, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

40.0% 40.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_202) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@elguardian
Copy link
Member

The root cause was fixed here. test. https://issues.redhat.com/browse/JBPM-8896
I don't think this is on 6.5.x branch. Already a test in there so there is no need for any additional test cases.
This patch will cover this situation. This is ok to go. @gmunozfe

@elguardian elguardian merged commit ece03f9 into kiegroup:master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmunozfe gmunozfe gmunozfe left review comments

@elguardian elguardian elguardian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@abhijithumbe @kie-ci @gmunozfe @elguardian