-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JBPM-9277] JMS Audit Data Replication in spring boot #1725
Conversation
52eb351
to
7452ecd
Compare
623854f
to
658d5d2
Compare
Jenkins retest this please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but got some comments before approving
jbpm-audit/src/main/java/org/jbpm/process/audit/AbstractAuditLoggerAdapter.java
Outdated
Show resolved
Hide resolved
jbpm-audit/src/main/java/org/jbpm/process/audit/AbstractAuditLoggerAdapter.java
Outdated
Show resolved
Hide resolved
jbpm-audit/src/main/java/org/jbpm/process/audit/AbstractAuditLoggerAdapter.java
Outdated
Show resolved
Hide resolved
jbpm-audit/src/main/java/org/jbpm/process/audit/AbstractAuditLoggerAdapter.java
Outdated
Show resolved
Hide resolved
...man-task-audit/src/main/java/org/jbpm/services/task/audit/JPATaskLifeCycleEventListener.java
Outdated
Show resolved
Hide resolved
jbpm-audit/src/main/java/org/jbpm/process/audit/JPAWorkingMemoryDbLogger.java
Outdated
Show resolved
Hide resolved
jbpm-audit/src/main/java/org/jbpm/process/audit/JPAWorkingMemoryDbLogger.java
Outdated
Show resolved
Hide resolved
jbpm-audit/src/main/java/org/jbpm/process/audit/JPAWorkingMemoryDbLogger.java
Outdated
Show resolved
Hide resolved
54cb29d
to
718673c
Compare
SonarCloud Quality Gate failed. 0 Bugs 31.4% Coverage The version of Java (1.8.0_202) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, looks good to me.
refactor task listeners and process listener to adapters
for data replication