Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBPM-9407] Spring Boot - Multiple Data Sources and Pluggable Variable Persistence #1769

Merged
merged 1 commit into from Nov 9, 2020

Conversation

elguardian
Copy link
Member

Jira https://issues.redhat.com/browse/JBPM-9407

Moving the code required for objects creating to a method so it could be overwritten

@elguardian
Copy link
Member Author

Jenkins retest this please.

Copy link
Member

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though a javadoc explaining the purpose of the protected method would be helpful.

Copy link
Contributor

@afalhambra afalhambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only a typo. Otherwise, it looks good to me.

Copy link
Contributor

@afalhambra afalhambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@sonarcloud
Copy link

sonarcloud bot commented Oct 29, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

77.8% 77.8% Coverage
0.0% 0.0% Duplication

@elguardian elguardian merged commit c0b0254 into kiegroup:master Nov 9, 2020
@elguardian elguardian deleted the JBPM-9407 branch November 9, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants