[JBPM-9459] Nested process instances abort doesn't work when a task in event subprocess is marked with "Is Async" as true #1797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elguardian
force-pushed
the
JBPM-9459
branch
from
98954e3
to
6792e1e
Compare
|
Jenkins retest this |
afalhambra
suggested changes
Nov 12, 2020
jbpm-flow/src/main/java/org/jbpm/workflow/instance/node/EventSubProcessNodeInstance.java
Outdated
Show resolved
Hide resolved
jbpm-test-coverage/src/test/resources/org/jbpm/test/functional/async/Exception.bpmn2
Outdated
Show resolved
Hide resolved
| </bpmn2:assignment> | ||
| </bpmn2:dataInputAssociation> | ||
| </bpmn2:task> | ||
| <bpmn2:task id="_1DBE0765-593C-45A8-B3AA-337A64D3062E" drools:taskName="Rest" name="REST"> |
There was a problem hiding this comment.
There's no need for a second task call actually. This can be removed.
jbpm-test-coverage/src/test/resources/org/jbpm/test/functional/async/Level1P.bpmn2
Outdated
Show resolved
Hide resolved
jbpm-test-coverage/src/test/resources/org/jbpm/test/functional/async/Level2C.bpmn2
Outdated
Show resolved
Hide resolved
jbpm-test-coverage/src/test/java/org/jbpm/test/functional/async/AsyncAdHocSubprocessTest.java
Outdated
Show resolved
Hide resolved
jbpm-test-coverage/src/test/java/org/jbpm/test/functional/async/AsyncAdHocSubprocessTest.java
Outdated
Show resolved
Hide resolved
jbpm-test-coverage/src/test/java/org/jbpm/test/functional/async/AsyncAdHocSubprocessTest.java
Show resolved
Hide resolved
jbpm-test-coverage/src/test/java/org/jbpm/test/functional/async/AsyncAdHocSubprocessTest.java
Outdated
Show resolved
Hide resolved
jbpm-test-coverage/src/test/java/org/jbpm/test/functional/async/AsyncAdHocSubprocessTest.java
Outdated
Show resolved
Hide resolved
|
@elguardian - I can see there're some failures in the CI tests. I noticed it's also failing in my local environment with this PR, just for you to know. |
…n event subprocess is marked with "Is Async" as true
elguardian
force-pushed
the
JBPM-9459
branch
from
6792e1e
to
cf058d3
Compare
|
@afalhambra fixed... some minor issue with the PR. |
afalhambra
approved these changes
Nov 12, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.redhat.com/browse/JBPM-9459