Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBPM-9503] Duplicate correlationkey for 2 active process instances #1816

Merged
merged 1 commit into from Dec 11, 2020

Conversation

elguardian
Copy link
Member

Copy link
Member

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typo to fix.
I also think that new line should be placed with the rest of "unique" constraints to keep coherence in the sql files.
Aren't migration scripts impacted by this?

Copy link
Contributor

@afalhambra afalhambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we take into account migration/upgrade scripts to include this new constraint? some typos

Copy link
Contributor

@afalhambra afalhambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I will run some tests on the different dbs to see if the issue is no longer happening.

However, I'm still wondering about the migration/upgrade scripts - are these not really needed? can you please clarify @elguardian? Thanks!

@sonarcloud
Copy link

sonarcloud bot commented Dec 11, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@elguardian
Copy link
Member Author

no about the migration, but database ddl.

@elguardian elguardian merged commit ef55b48 into kiegroup:master Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants