New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JBPM-9503] Duplicate correlationkey for 2 active process instances #1816
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some typo to fix.
I also think that new line should be placed with the rest of "unique" constraints to keep coherence in the sql files.
Aren't migration scripts impacted by this?
jbpm-db-scripts/src/main/resources/db/ddl-scripts/db2/db2-jbpm-schema.sql
Outdated
Show resolved
Hide resolved
jbpm-db-scripts/src/main/resources/db/ddl-scripts/db2/db2-jbpm-schema.sql
Outdated
Show resolved
Hide resolved
jbpm-db-scripts/src/main/resources/db/ddl-scripts/h2/h2-jbpm-schema.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we take into account migration/upgrade scripts to include this new constraint? some typos
jbpm-db-scripts/src/main/resources/db/ddl-scripts/db2/db2-jbpm-schema.sql
Outdated
Show resolved
Hide resolved
jbpm-db-scripts/src/main/resources/db/ddl-scripts/h2/h2-jbpm-schema.sql
Outdated
Show resolved
Hide resolved
64a4bce
to
c9632f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I will run some tests on the different dbs to see if the issue is no longer happening.
However, I'm still wondering about the migration/upgrade scripts - are these not really needed? can you please clarify @elguardian? Thanks!
Kudos, SonarCloud Quality Gate passed! |
no about the migration, but database ddl. |
Jira: https://issues.redhat.com/browse/JBPM-9503