Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JBPM-9641] Convert process variable to right data type #1890

Merged
merged 1 commit into from Mar 23, 2021
Merged

[JBPM-9641] Convert process variable to right data type #1890

merged 1 commit into from Mar 23, 2021

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Mar 4, 2021 •
edited

JIRA:

link

referenced Pull Requests:
kiegroup/droolsjbpm-integration#2419

@fjtirado fjtirado marked this pull request as draft March 4, 2021 17:19
@fjtirado fjtirado requested a review from afalhambra March 4, 2021 17:19
@fjtirado fjtirado force-pushed the JBPM-9641 branch 6 times, most recently from 5102dfc to e18b689 Compare March 4, 2021 18:49
@fjtirado fjtirado mentioned this pull request Mar 4, 2021
Closed
@fjtirado fjtirado marked this pull request as ready for review March 4, 2021 19:27
@fjtirado fjtirado marked this pull request as draft March 4, 2021 20:32
@fjtirado fjtirado marked this pull request as ready for review March 4, 2021 20:46
@gmunozfe
Copy link
Member

gmunozfe commented Mar 8, 2021

jenkins retest this

afalhambra
afalhambra approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@afalhambra afalhambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @fjtirado!

jbpm-flow/src/main/java/org/jbpm/process/core/datatype/impl/type/EnumDataType.java Outdated Show resolved Hide resolved
jbpm-flow/src/main/java/org/jbpm/process/core/datatype/DataType.java Outdated Show resolved Hide resolved
@fjtirado fjtirado mentioned this pull request Mar 9, 2021
Merged
gmunozfe
gmunozfe approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, marvellous work @fjtirado !

@fjtirado
Copy link
Contributor Author

jenkins retest this

1 similar comment
@fjtirado
Copy link
Contributor Author

jenkins retest this

@fjtirado
Copy link
Contributor Author

fjtirado commented Mar 11, 2021 •
edited

jenkins retest this (failed because unrelated timeout, but just in case)

@fjtirado fjtirado force-pushed the JBPM-9641 branch 3 times, most recently from bff042a to 6aad20e Compare March 12, 2021 09:35
@fjtirado
Copy link
Contributor Author

@elguardian finally green, please take another look

elguardian
elguardian requested changes Mar 18, 2021
View reviewed changes
Copy link
Member

@elguardian elguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the impl plz, this one could cause some problems.

@sonarcloud
Copy link

sonarcloud bot commented Mar 18, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.6% 83.6% Coverage
0.0% 0.0% Duplication

@elguardian elguardian merged commit b5bb2b6 into kiegroup:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmunozfe gmunozfe gmunozfe approved these changes

@afalhambra afalhambra afalhambra approved these changes

@elguardian elguardian Awaiting requested review from elguardian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@fjtirado @gmunozfe @elguardian @afalhambra