Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBPM-9699] Register WorkItemHandler when kafka extension is enabled #1918

Merged
merged 1 commit into from May 6, 2021

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Apr 15, 2021

Do not assume message is a string in default handler

JIRA:

link

referenced Pull Requests:
kiegroup/droolsjbpm-integration#2455
kiegroup/droolsjbpm-knowledge#515

Copy link
Member

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, well done @fjtirado !

Do not assume message is a string in default handler
Moving merger from jbpm to kie internal
@fjtirado
Copy link
Contributor Author

jenkins retest this

2 similar comments
@fjtirado
Copy link
Contributor Author

jenkins retest this

@fjtirado
Copy link
Contributor Author

jenkins retest this

@sonarcloud
Copy link

sonarcloud bot commented Apr 30, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@gmunozfe gmunozfe self-requested a review May 6, 2021 11:16
Copy link
Member

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to delete moved test class: DeploymentDescriptorMergerTest.
I think DeploymentDescriptorManagerTest should be also moved

@elguardian elguardian merged commit 59ef2ee into kiegroup:master May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants