Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JBPM-9706] Create Native SQL command to operate database to execute functions / SQL queries and stores in the execution results #1919

Merged
merged 1 commit into from May 13, 2021
Merged

[JBPM-9706] Create Native SQL command to operate database to execute functions / SQL queries and stores in the execution results #1919

merged 1 commit into from May 13, 2021

Conversation

elguardian
Copy link
Member

No description provided.

@elguardian
Copy link
Member Author

Jenkins retest this please

@elguardian elguardian force-pushed the JBPM-9706 branch 4 times, most recently from 8f142d2 to deced6d Compare April 28, 2021 07:01
@elguardian
Copy link
Member Author

Jenkins retest this please

@elguardian
Copy link
Member Author

Jenkins retest this please

4 similar comments
@elguardian
Copy link
Member Author

Jenkins retest this please

@elguardian
Copy link
Member Author

Jenkins retest this please

@elguardian
Copy link
Member Author

Jenkins retest this please

@elguardian
Copy link
Member Author

Jenkins retest this please

@elguardian elguardian force-pushed the JBPM-9706 branch 4 times, most recently from 198a105 to ae9e567 Compare May 6, 2021 14:26
@elguardian elguardian requested a review from afalhambra May 6, 2021 14:27
@elguardian
Copy link
Member Author

Jenkins retest this please

1 similar comment
@elguardian
Copy link
Member Author

Jenkins retest this please

@sonarcloud
Copy link

sonarcloud bot commented May 7, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

afalhambra
afalhambra reviewed May 10, 2021
View reviewed changes
Copy link
Contributor

@afalhambra afalhambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! - just only some cosmetic and maybe a test case would be good to have.

.../jbpm-shared-services/src/main/java/org/jbpm/shared/services/impl/JpaPersistenceContext.java Outdated Show resolved Hide resolved
...-services/jbpm-executor/src/main/java/org/jbpm/executor/commands/ExecuteSQLQueryCommand.java Outdated Show resolved Hide resolved
...-services/jbpm-executor/src/main/java/org/jbpm/executor/commands/ExecuteSQLQueryCommand.java Outdated Show resolved Hide resolved
...-services/jbpm-executor/src/main/java/org/jbpm/executor/commands/ExecuteSQLQueryCommand.java Show resolved Hide resolved
...-services/jbpm-executor/src/main/java/org/jbpm/executor/commands/ExecuteSQLQueryCommand.java Show resolved Hide resolved
@elguardian
[JBPM-9706] Create Native SQL command to operate database to execute …
1a44c30 
…functions / SQL queries and stores in the execution results
afalhambra
afalhambra approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@afalhambra afalhambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice job

@elguardian elguardian merged commit 2039291 into kiegroup:master May 13, 2021
@elguardian elguardian deleted the JBPM-9706 branch May 13, 2021 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afalhambra afalhambra afalhambra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@elguardian @afalhambra