[JBPM-9735] Improve jbpm engine Message and Signal #1943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elguardian
force-pushed
the
JBPM-9735
branch
2 times, most recently
from
9118c7f
to
67c3b8d
Compare
|
Jenkins retest this please |
|
Jenkins retest this please |
gmunozfe
suggested changes
Jun 8, 2021
There was a problem hiding this comment.
Looks good to me, huge and fabulous work @elguardian !
Check some typos (especially with metadata) and other minor comments.
It'd be great to add some more testing regarding edge conditions or events catching in subprocesses.
jbpm-flow/src/main/java/org/jbpm/process/core/correlation/Correlation.java
Outdated
Show resolved
Hide resolved
jbpm-flow/src/main/java/org/jbpm/process/core/correlation/CorrelationInstance.java
Show resolved
Hide resolved
jbpm-flow/src/main/java/org/jbpm/process/core/correlation/Message.java
Outdated
Show resolved
Hide resolved
jbpm-bpmn2/src/main/java/org/jbpm/bpmn2/core/Collaboration.java
Outdated
Show resolved
Hide resolved
jbpm-bpmn2/src/main/java/org/jbpm/bpmn2/core/CorrelationKey.java
Outdated
Show resolved
Hide resolved
jbpm-flow/src/main/java/org/jbpm/process/core/correlation/CorrelationManager.java
Outdated
Show resolved
Hide resolved
jbpm-flow/src/main/java/org/jbpm/process/core/event/EventTypeFilter.java
Outdated
Show resolved
Hide resolved
jbpm-flow/src/main/java/org/jbpm/process/core/event/MVELMessageExpressionEvaluator.java
Show resolved
Hide resolved
jbpm-flow/src/main/java/org/jbpm/process/core/event/MVELMessageExpressionEvaluator.java
Show resolved
Hide resolved
jbpm-test-coverage/src/test/java/org/jbpm/test/functional/collaboration/CollaborationTest.java
Show resolved
Hide resolved
gmunozfe
reviewed
Jun 10, 2021
jbpm-bpmn2/src/main/java/org/jbpm/bpmn2/core/Collaboration.java
Outdated
Show resolved
Hide resolved
jbpm-flow/src/main/java/org/jbpm/process/core/correlation/CorrelationManager.java
Outdated
Show resolved
Hide resolved
|
Jenkins retest this please. |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.redhat.com/browse/JBPM-9735