Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JBPM-9798] Accept all possible properties for Kafka Consumer/Producer #1967

Merged
merged 1 commit into from Jul 1, 2021
Merged

[JBPM-9798] Accept all possible properties for Kafka Consumer/Producer #1967

merged 1 commit into from Jul 1, 2021

Conversation

fjtirado
Copy link
Contributor

Adding functionality for Kafka event emitter

JIRA:

link

@fjtirado
Copy link
Contributor Author

jenkins retest this

elguardian
elguardian approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@elguardian elguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gmunozfe
gmunozfe approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, stupendous work @fjtirado !
You can even add the properties for ScramLoginModule but up to you, I've checked that works like a charm

@fjtirado
Copy link
Contributor Author

jenkins retest this

@sonarcloud
Copy link

sonarcloud bot commented Jun 30, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@elguardian elguardian merged commit f5bacb0 into kiegroup:master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmunozfe gmunozfe gmunozfe approved these changes

@elguardian elguardian elguardian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@fjtirado @gmunozfe @elguardian