Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JBPM-9882] - Adding actual owner to TaskEvent #2032

Merged
merged 2 commits into from Oct 4, 2021

Conversation

afalhambra
Copy link
Contributor

@afalhambra afalhambra commented Sep 28, 2021

JBPM-9882: Adding actual owner to TaskEvent

referenced Pull Requests:

How to retest this PR or trigger a specific build:
  • a pull request please add comment: Jenkins retest this

  • a full downstream build please add comment: Jenkins run fdb

  • a compile downstream build please add comment: Jenkins run cdb

  • a full production downstream build please add comment: Jenkins execute product fdb

  • an upstream build please add comment: Jenkins run upstream

@afalhambra
Copy link
Contributor Author

Jenkins retest this

Task ti = event.getTask();
if(ti.getTaskData().getProcessId() != null){
userId = ti.getTaskData().getProcessId();
}
Copy link
Member

@gmunozfe gmunozfe Sep 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing tests due to this removal, I think it's a fix (though result changes) because here it's overwriting the userId from the context. IMO, test assertion should be changed to "testUser"

Comment on lines -280 to -282
if(ti.getTaskData().getProcessId() != null){
userId = ti.getTaskData().getProcessId();
}
Copy link
Member

@gmunozfe gmunozfe Sep 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@sonarcloud
Copy link

sonarcloud bot commented Sep 30, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@elguardian elguardian merged commit 17d85bb into kiegroup:main Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants