Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JBPM-10005] Add suspendUntil timer to getTimers call #2093

Merged
merged 1 commit into from Feb 2, 2022
Merged

[JBPM-10005] Add suspendUntil timer to getTimers call #2093

merged 1 commit into from Feb 2, 2022

Conversation

elguardian
Copy link
Member

@elguardian
Copy link
Member Author

test will be included afterwards.... as it will collide with
https://github.com/kiegroup/jbpm/pull/2092/files

@sonarcloud
Copy link

sonarcloud bot commented Jan 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

50.0% 50.0% Coverage
0.0% 0.0% Duplication

gmunozfe
gmunozfe approved these changes Feb 1, 2022
View reviewed changes
Copy link
Member

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, great approach @elguardian !
Just pending to add a test when possible

@elguardian elguardian merged commit 1066f8e into kiegroup:main Feb 2, 2022
@elguardian elguardian deleted the JBPM-10005 branch February 2, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmunozfe gmunozfe gmunozfe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@elguardian @gmunozfe